[HOLD for payment 2024-08-05] [$250] Sage Intacct - Workspace in "Reuse existing connection" list has different workspace avatar color

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• User has a few workspaces.
• One of the workspaces is connected to Sage Intacct.
• The workspace which is connected to Sage Intacct has default workspace avatar.

1. Go to staging.new.expensify.com
2. Go to another workspace that is not connected to Sage Intacct.
3. Go to Accounting.
4. Tap Connect next to Sage Intacct.
5. Select Reuse existing connection.

Expected Result:

The workspace in "Reuse existing connection" list will have the correct workspace avatar with background color.

Actual Result:

The workspace in "Reuse existing connection" list has different workspace avatar compared to the actual workspace avatar with always blue background color surrounding the letter "A".

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6548213_1721494812873.20240721_001045.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0140511183d3b4ac7e
• Upwork Job ID: 1815697022094043995
• Last Price Increase: 2024-07-23
• Automatic offers:
• ishpaul777 | Reviewer | 103247884
• gijoe0295 | Contributor | 103247885

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Default workspace avatar mismatch in existing connections page.

What is the root cause of that problem?

We're missing avatarID causing the avatar background to be computed incorrectly:

App/src/pages/workspace/accounting/intacct/ExistingConnectionsPage.tsx

Lines 29 to 33 in c3b1ff2

	title: policy.name,
	key: policy.id,
	icon: policy.avatarURL ? policy.avatarURL : ReportUtils.getDefaultWorkspaceAvatar(policy.name),
	iconType: policy.avatarURL ? CONST.ICON_TYPE_AVATAR : CONST.ICON_TYPE_WORKSPACE,
	description: date ? translate('workspace.common.lastSyncDate', CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY.intacct, date) : translate('workspace.accounting.intacct'),

App/src/components/Avatar.tsx

Lines 97 to 98 in 6562f74

	if (isWorkspace) {
	iconColors = StyleUtils.getDefaultWorkspaceAvatarColor(avatarID?.toString() ?? '');

What changes do you think we should make in order to solve the problem?

Add avatarID as policy.id for the above menuItems.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0140511183d3b4ac7e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)