[HOLD for payment 2024-08-13] [$250] mWeb - Workspace - In archived workspace, in iou details page sideways caret are shown for fields

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home

2. Tap on a workspace chat

3. Submit an expense entering all fields

4. Navigate to LHN

5. Tap profile icon -- workspaces -- workspace

6. Tap on 3 dots icon next to workspace

7. Delete the workspace

8. Navigate to LHN

9. Open the archived workspace chat

10. Open the IOU

11. Open amount and description field using sideways caret

12. Note hhm not here page is shown

Expected Result:

Like in task details page, sideways caret must not be shown in iou details page in archived workspace

Actual Result:

In archived workspace, in iou details page sideways caret for amount & description field are shown directing to hhm not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547855_1721460264010.Screenrecorder-2024-07-20-12-37-14-543_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019bd42da3fc0d7c59
• Upwork Job ID: 1815412203411994715
• Last Price Increase: 2024-07-22
• Automatic offers:
• dominictb | Contributor | 103308909

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Выпуск 1

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - Workspace - In archived workspace, in iou details page sideways caret are shown for fields

What is the root cause of that problem?

• We aren't checking for archived room in canEditMoneyRequest util function.
  

  App/src/libs/ReportUtils.ts

  Line 2667 in f3a8f73

  function canEditMoneyRequest(reportAction: OnyxInputOrEntry<ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.IOU>>): boolean {

• There is one more issue in isDeletedAction util function, it doesn't check if the action does has pending delete action.
  

  App/src/libs/ReportActionsUtils.ts

  Lines 113 to 124 in f3a8f73

  	function isDeletedAction(reportAction: OnyxInputOrEntry<ReportAction | OptimisticIOUReportAction>): boolean {
  	const message = reportAction?.message ?? [];
  	if (!Array.isArray(message)) {
  	return message?.html === '' ?? message?.deleted;
  	}
  	// A legacy deleted comment has either an empty array or an object with html field with empty string as value
  	const isLegacyDeletedComment = message.length === 0 || message[0]?.html === '';
  	return isLegacyDeletedComment || !!message[0]?.deleted;
  	}

What changes do you think we should make in order to solve the problem?

• Add archived room check in canEditMoneyRequest and return false if repot is archived.

    if (isArchivedRoom(moneyRequestReport, getReportNameValuePairs(moneyRequestReport?.reportID))) {
        return false;
    }

• Update isDeletedAction to also check for pending action and return true if reportAction?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE is true.

    if (!reportAction || reportAction?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
        return true;
    }

What alternative solutions did you explore? (Optional)

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• In archived workspace, in iou details page sideways caret for amount & description field are shown directing to hhm not here page

What is the root cause of that problem?

• In each field in money request view, we allow user to click on it if user can edit that field and that field is not readonly. For example, the amount field:
  

  App/src/components/ReportActionItem/MoneyRequestView.tsx

  Line 492 in f3a8f73

  interactive={canEditAmount && !readonly}

• But, in IOURequestStepAmount, beside the above check, we use additional check in withWritableReportOrNotFound, which will display the not found page if:
  

  App/src/pages/iou/request/step/withWritableReportOrNotFound.tsx

  Line 62 in f3a8f73

  const canUserPerformWriteAction = ReportUtils.canUserPerformWriteAction(report);

  
  is false.

What changes do you think we should make in order to solve the problem?

• For each field in money request view, we should add an additional check like:
  

  App/src/pages/iou/request/step/withWritableReportOrNotFound.tsx

  Line 62 in f3a8f73

  const canUserPerformWriteAction = ReportUtils.canUserPerformWriteAction(report);

• For example, with amount field:
  

  App/src/components/ReportActionItem/MoneyRequestView.tsx

  Line 506 in f3a8f73

  interactive={canEdit && !readonly}

  
  will become:

                        interactive={canUserPerformWriteAction && canEditAmount && !readonly}
                        shouldShowRightIcon={canUserPerformWriteAction && canEditAmount}

with:

    const canUserPerformWriteAction = ReportUtils.canUserPerformWriteAction(report);

[Krishna2323]

Proposal Updated

• Found one more issue in isDeletedAction util function and added RCA and solution for that.

[joekaufmanexpensify]

This doesn't seem to be happening only on Android. I reproduced it on Chrome web. I also don't think the task steps are necessary for reproducing. They help show that you can't edit fields on a task with an archived workspace, but I removed them from OP to make the bug easier to reproduce.

[joekaufmanexpensify]

Makes sense to me that we wouldn't allow you to edit any fields on an expense when the workspace it's reported on is archived.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019bd42da3fc0d7c59