[HOLD for payment 2024-08-13] [$250] [Held requests] Partially approved expenses are not GBR'ed in LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4747965
Issue reported by: Applause - Internal Team

Action Performed:

Pre-requisite:

1. Create a workspace and add user A (as a member) and user B (as an admin).
2. More features > Enable workflows > Enable Add Approvals > Set user B as an approver
   Steps
3. As user A submit two expenses to the workspace
4. As user B (the approver) navigate to the expense report and hold one of the expenses
5. As user B (the approver) click on the approve option
6. A modal is displayed to approve the full report amount or just the pending expense
7. Approve the pending expense (Submitted expense that is not on hold)
8. When the action is completed observe the LHN and workspace chat report.

Expected Result:

A new report is created with the expense on hold and is GBR’ed in the LHN (green dot)

Actual Result:

A new report is created with the expense on hold but is not GBR’ed in the LHN (green dot)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6549292_1721646141815.2024-07-22_13_36_59.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0130a7781bd6d708e1
• Upwork Job ID: 1816612436734076568
• Last Price Increase: 2024-07-25
• Automatic offers:
• ikevin127 | Reviewer | 103312301
• nkdengineer | Contributor | 103312306

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[VictoriaExpensify]

Ok I've recreated the issue and agree it should be fixed:

I think this is part of Wave Collect.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0130a7781bd6d708e1