[HOLD for payment 2024-08-07] [$250] Chat - Not here page does not have back button

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Open a chat and send a comment
3. Copy the link of the comment sent on step 2
4. Paste the link on the URL and add random numbers at the end and navigate to it

Expected Result:

The not here page have back button at the top left corner

Actual Result:

Not here page which gets displayed doesn't have any back button even if other "don't have access" pages have the back button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6549442_1721654662608.Screen_Recording_20240722_161807_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dbe85c3ec54018bc
• Upwork Job ID: 1815414741380280360
• Last Price Increase: 2024-07-22

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[ishpaul777]

maybe from #44488, reverting locally to confirm

[ishpaul777]

sorry it didn't work i was not able see not found page at all after straight reverting(Pr here- #45914 )

Screen.Recording.2024-07-22.at.8.15.09.PM.mov

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no back button when linking to a not found action.

What is the root cause of that problem?

If we look at the code, the not found page when the linked action is not found never has a header with a back button.

App/src/pages/home/ReportScreen.tsx

Lines 736 to 757 in ccf9591

	if (
	(!isLinkedActionInaccessibleWhisper && isLinkedActionDeleted) ||
	(shouldShowSkeleton &&
	!reportMetadata.isLoadingInitialReportActions &&
	reportActionIDFromRoute &&
	sortedAllReportActions &&
	sortedAllReportActions?.length > 0 &&
	reportActions.length === 0 &&
	!isLinkingToMessage)
	) {
	return (
	<BlockingView
	icon={Illustrations.ToddBehindCloud}
	iconWidth={variables.modalTopIconWidth}
	iconHeight={variables.modalTopIconHeight}
	title={translate('notFound.notHere')}
	shouldShowLink
	linkKey="notFound.noAccess"
	onLinkPress={navigateToEndOfReport}
	/>
	);
	}

It was added in 104884a the first time. #44488 fixes the not found condition which now shows the not found correctly when the linked action doesn't found, just like when it's introduced.

So, this is a feature request to show the header.

What changes do you think we should make in order to solve the problem?

We can add a header with a back button above the blocking view component.

<>
<HeaderWithBackButton shouldShowBackButton={shouldUseNarrowLayout} onBackButtonPress={navigateToEndOfReport}/>
<BlockingView />
</>

We only show it on narrow layout and the back press will call the same function as onLinkPress of the blocking view, that is to clear the report action route params.