[HOLD for payment 2024-08-14] [$250] Wallet - State is not auto filled after selecting the address during "Get physical card" flow

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in to account that has Expensify Card (applausetester@applause.expensifail.com
   ).
3. Go to Account settings > Wallet
4. Click on the second Expensify card (for applausetester@applause.expensifail.com
   )
5. Click Get physical card
6. Enter phone number
7. Proceed to "Enter your shipping address" step
8. Enter address and select address from the suggestion list

Expected Result:

State will be auto filled after selecting the address

Actual Result:

State is not auto filled after selecting the address

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6549534_1721659457149.bandicam_2024-07-22_22-40-13-630.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bc16c42b34fa53cc
• Upwork Job ID: 1816816721648392124
• Last Price Increase: 2024-07-26
• Automatic offers:
• DylanDylann | Reviewer | 103345980
• nkdengineer | Contributor | 103345985

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[lanitochka17]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wallet - State is not auto filled after selecting the address during "Get physical card" flow

What is the root cause of that problem?

We are using the wrong prop defaultValue for passing the state value to StateSelector.

App/src/components/AddressForm.tsx

Lines 192 to 198 in 1efdcc0

	<InputWrapper
	InputComponent={StateSelector}
	inputID={INPUT_IDS.STATE}
	defaultValue={state}
	onValueChange={onAddressChanged}
	shouldSaveDraft={shouldSaveDraft}
	/>

What changes do you think we should make in order to solve the problem?

We should be using value prop instead of defaultValue prop because that is expected inside StateSelector.

App/src/components/StateSelector.tsx

Lines 40 to 43 in 1efdcc0

	function StateSelector(
	{errorText, onBlur, value: stateCode, label, onInputChange, wrapperStyle, stateSelectorRoute = ROUTES.SETTINGS_ADDRESS_STATE}: StateSelectorProps,
	ref: ForwardedRef<View>,
	) {

We should also check in other places.

What alternative solutions did you explore? (Optional)

Result

address_state_auto_fill_issu.mp4

[zanyrenney]

adding an external label, the bug is reproducible.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bc16c42b34fa53cc