[HOLD for Payment 2024-09-3][$125] Categorizing - Distance rate list is empty when workspace is non-existent during categorizing

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Account has no workspace

1. Go to staging.new.expensify.com
2. Go to self DM
3. Track a distance expense
4. Click Categorize it
5. Select a category
6. Proceed to confirmation page
7. Click Rate on confirmation page

Expected Result:

Rate list should display the workspace distance rate

Actual Result:

Rate list is empty
This issue only happens when there is no workspace in the account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6549648_1721664230739.bandicam_2024-07-22_23-48-57-217.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b13e9e624d638835
• Upwork Job ID: 1818860377251381062
• Last Price Increase: 2024-08-30
• Automatic offers:
• dominictb | Contributor | 103403381

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Rate list is empty
This issue only happens when there is no workspace in the account

What is the root cause of that problem?

There're 2 problems:

1. We're getting rates from policy

App/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx

Line 118 in c47208e

rates: {

It's not correct, since after users click categorize it, we just create the draft policy -> rates are undefined

2. In MoneyRequestConfirmationList we're getting mileageRates so it will be empty object

App/src/components/MoneyRequestConfirmationList.tsx

Line 909 in c47208e

key: ({policyID}) => `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,

What changes do you think we should make in order to solve the problem?

1. we should get the policyDraft and rateDrafts and get the actual policy/rates as what we already did in here

In IOURequestStepDistanceRate

    const policy = policyReal ?? policyDraft
    const rates = isEmpty(rates) ? rateDrafts : rates

... 
const IOURequestStepDistanceRateWithOnyx = withOnyx<IOURequestStepDistanceRateProps, IOURequestStepDistanceRateOnyxProps>({
...
export default withOnyx<MoneyRequestConfirmationListProps, MoneyRequestConfirmationListOnyxProps>({
...
    policyDraft: {
        key: ({reportDraft, transaction}) => `${ONYXKEYS.COLLECTION.POLICY_DRAFTS}${IOU.getIOURequestPolicyID(transaction, reportDraft)}`,
    },
    rateDrafts: {
        key: ({reportDraft, transaction}) => `${ONYXKEYS.COLLECTION.POLICY_DRAFTS}${IOU.getIOURequestPolicyID(transaction, reportDraft)}`,
        selector: (policy: OnyxEntry<Policy>) => DistanceRequestUtils.getMileageRates(policy),
    },

2. Get the draft mileageRates
   In MoneyRequestConfirmationList

    const mileageRates = isEmpty(mileageRatesReal) ? mileageRatesDraft: mileageRatesReal;
...

...
    mileageRatesDraft: {
        key: ({policyID}) => `${ONYXKEYS.COLLECTION.POLICY_DRAFTS}${policyID}`,
        selector: (policy: OnyxEntry<OnyxTypes.Policy>) => DistanceRequestUtils.getMileageRates(policy),
    },

What alternative solutions did you explore? (Optional)

NA

Result

web-resize.mp4

[melvin-bot]

@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@adelekennedy 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b13e9e624d638835