[HOLD for payment 2024-08-19] [TS] Memoize utility lacks correct typings for transformKey option when called with constructable

[kacper-mikolajczak]

Details

This is a known regression, which originates from #43868

memoize module lacks correct typings for transformKey option when called with constructables (entities which are initialized with new keyword).

Steps to reproduce

1. Wrap constructable (some class for example) with memoize method
2. Pass configuration (second argument) with transformKey callback
3. Check the typings of transformKey callback's arguments

Expected behaviour

transformKey arguments match constructor's arguments

Actual behaviour

transformKey arguments are typed as readonly [] (empty tuple)

[melvin-bot]

Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA][TS] Memoize constructable types #46280

If no regressions arise, payment will be issued on 2024-08-19. 🎊