[Payment due Sept 6] [$250] Search - Expense page composer loses bottom margin when going offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.13-3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): bezawitgebremichael+11221122@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
*

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create an expense
3. Go to search
4. Click on an expense from the expense list
5. Go offline

Expected Result:

There will be an offline indicator under the composer and the composer will have a bottom margin

Actual Result:

The composer does not have a bottom margin and there is no offline indicator

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6554985_1722117881417.4_5848162808948069413.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a491780ac50be9ec
• Upwork Job ID: 1817922651827967932
• Last Price Increase: 2024-07-29

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

Production

Recording.2656.mp4

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense page composer loses bottom margin when going offline

What is the root cause of that problem?

if isOffline we set the minHeight to 0 here

App/src/pages/home/report/ReportFooter.tsx

Line 101 in 66ebb3e

const chatFooterStyles = {...styles.chatFooter, minHeight: !isOffline ? CONST.CHAT_FOOTER_MIN_HEIGHT : 0};

And we no longer show the OfflineIndicator here since we change the condition from !isSmallScreenWidth to !shouldUseNarrowLayout on this PR

App/src/pages/home/report/ReportFooter.tsx

Lines 194 to 196 in 66ebb3e

	{!shouldUseNarrowLayout && (
	<View style={styles.offlineIndicatorRow}>{shouldHideComposer && <OfflineIndicator containerStyles={[styles.chatItemComposeSecondaryRow]} />}</View>
	)}

What changes do you think we should make in order to solve the problem?

set the minHeight to 0 only if isOffline && !shouldUseNarrowLayout

const chatFooterStyles = {...styles.chatFooter, minHeight: isOffline && !shouldUseNarrowLayout ? 0 : CONST.CHAT_FOOTER_MIN_HEIGHT};

RESULT

What alternative solutions did you explore? (Optional)