[HOLD for Payment 2024-09-02] [$250] Send invoice - Individual workspace is in 'Send from' field

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3073286
Email or phone of affected tester (no customers): applausetester+bp716@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: account has Individual workspace as default and at least one existing group workspace.

1. FAB > Send invoice
2. Enter amount > Next
3. Choose a user

Expected Result:

The 'Send from' default workspace is one of listed sender's existing default workspaces.

Actual Result:

The 'Send from' default workspace is Individual workspace. When click on field, the list of sender's existing workspaces is displayed. But if you change the default workspace (one of group WS in OldDot), the individual WS is not displayed in the list.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6559066_1722589049090.individual_ws.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0107661f51eb3a2eee
• Upwork Job ID: 1821429613810291281
• Last Price Increase: 2024-08-08
• Automatic offers:
• rojiphil | Reviewer | 103496757
• nkdengineer | Contributor | 103496758

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-bills.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Individual workspace is in 'Send from' field

What is the root cause of that problem?

We return the default policy on getPrimaryPolicy function without excluding the personal policy

App/src/libs/actions/Policy/Policy.ts

Lines 205 to 210 in 30cfaef

	function getPrimaryPolicy(activePolicyID?: OnyxEntry<string>): Policy | undefined {
	const activeAdminWorkspaces = PolicyUtils.getActiveAdminWorkspaces(allPolicies);
	const primaryPolicy: Policy | null | undefined = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID ?? '-1'}`];
	return primaryPolicy ?? activeAdminWorkspaces[0];
	}

What changes do you think we should make in order to solve the problem?

return the first activeAdminWorkspaces if the type of default policy is personal

    if (primaryPolicy?.type === CONST.POLICY.TYPE.PERSONAL) {
        return activeAdminWorkspaces[0];
    }

What alternative solutions did you explore? (Optional)

[github-actions]

true

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The 'Send from' default workspace is Individual workspace. When click on field, the list of sender's existing workspaces is displayed. But if you change the default workspace (one of group WS in OldDot), the individual WS is not displayed in the list.

What is the root cause of that problem?

We always set the default WS in the send invoice flow is the default WS if it exists without checking it is a personal WS or not

App/src/libs/actions/Policy/Policy.ts

Lines 205 to 209 in fefda46

	function getPrimaryPolicy(activePolicyID?: OnyxEntry<string>): Policy | undefined {
	const activeAdminWorkspaces = PolicyUtils.getActiveAdminWorkspaces(allPolicies);
	const primaryPolicy: Policy | null | undefined = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID ?? '-1'}`];
	return primaryPolicy ?? activeAdminWorkspaces[0];

What changes do you think we should make in order to solve the problem?

Instead of getting primaryPolicy from allPolicies, we can get this policy from the activeAdminWorkspaces which already filtered the hidden policy

function getPrimaryPolicy(activePolicyID?: OnyxEntry<string>): Policy | undefined {
    const activeAdminWorkspaces = PolicyUtils.getActiveAdminWorkspaces(allPolicies);
    const primaryPolicy: Policy | null | undefined = activeAdminWorkspaces.find((policy) => policy.id === activePolicyID);
    return primaryPolicy ?? activeAdminWorkspaces[0];
}

App/src/libs/actions/Policy/Policy.ts

Lines 205 to 209 in fefda46

	function getPrimaryPolicy(activePolicyID?: OnyxEntry<string>): Policy | undefined {
	const activeAdminWorkspaces = PolicyUtils.getActiveAdminWorkspaces(allPolicies);
	const primaryPolicy: Policy | null | undefined = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID ?? '-1'}`];
	return primaryPolicy ?? activeAdminWorkspaces[0];

What alternative solutions did you explore? (Optional)

[melvin-bot]

@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[adelekennedy]

I can't seem to recreate this on v9.0.16-5 - @izarutskaya can you still reproduce this?