Distance - System message contains blank info when submitting expense and editing rate offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

• Workspace has a few distance rates

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Go offline
4. Submit a distance expense
5. Go to transaction thread
6. Click Rate
7. Select a different rate

Expected Result:

The system message should only appear after returning online as it contains incorrect before and after amount - "which updated the amount to $0.00 (previously )"

Actual Result:

The system message is not accurate and contains blank info. It shows "which updated the amount to $0.00 (previously )". The previous amount is blank, the new amount is $0.00 which is also not accurate. The message should only appear after returning online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6563402_1722951149936.20240806_212613.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to ##wave-collect - Release 1

[marcochavezf]

Seems this was introduced here and seems the Edit Rate is a new feature cc @neil-marcellini @paultsimura

[neil-marcellini]

Not a blocker, under the P2P distance beta. I agree with the expected result that the modified expense message shouldn't appear until we come back online.