[PAY AUG 22ND][$250] Search-Skeleton during loading & in empty state are aligned differently compared to production

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go back to Inbox.
4. Open workspace switcher and select the new workspace.
5. Go to Search.
6. Navigate through the empty Search sections to check how the skeleton during loading and the skeleton in empty state are aligned differently on staging and production.

Expected Result:

The skeleton during loading and the skeleton in empty state should have similar alignment (only slight deviation on production).

Actual Result:

The skeleton during loading and the skeleton in empty state has larger deviation in alignment compared to production.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6564170_1723020514064.20240807_164018.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011af2fbb0ab06fc24
• Upwork Job ID: 1821143733082880779
• Last Price Increase: 2024-08-07
• Automatic offers:
• rayane-djouah | Contributor | 103432889

Issue Owner

Current Issue Owner: @jayeshmangwani

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Skeleton during loading & in empty state are aligned differently compared to production

What is the root cause of that problem?

The margin of the skeleton view not properly set

What changes do you think we should make in order to solve the problem?

Add proper margin here to make it consistent to the empty state

style={[themeStyles.flex1, themeStyles.overflowHidden, themeStyles.m2, themeStyles.mt3]}

OR

style={[themeStyles.flex1, themeStyles.overflowHidden, themeStyles.mt3, themeStyles.mb2, themeStyles.mr2, themeStyles.ml2]}

RESULT

New-Expensify.27.mp4

What alternative solutions did you explore? (Optional)