[HOLD for payment][$250] - LHN preview is missing distance rate name in distance rate removal system message

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4827991
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace has some distance rates

1. Go to staging.new.expensify.com
2. Go to workspace settings > Distance rates
3. Delete a distance rate
4. Go to #admins room of the same workspace
5. Refresh the page

Expected Result:

The LHN preview will display the complete distance rate removal system message

Actual Result:

The LHN preview is missing the name of the removed distance rate in the system message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6564191_1723021787060.20240807_170549.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016424eee2de4a22ba
• Upwork Job ID: 1821384517474279929
• Last Price Increase: 2024-08-22
• Automatic offers:
• FitseTLT | Contributor | 103698148

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[lanitochka17]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-08-07 19:39:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN preview is missing distance rate name in distance rate removal system message

What is the root cause of that problem?

In getOptionData we are not dealing with POLICY_CHANGE_LOG.DELETE_CUSTOM_UNIT_RATE action types when getting alternateText for the LHN so it is falling back to setting it to the lastMessage of the report which misses distance rate name

App/src/libs/SidebarUtils.ts

Lines 431 to 432 in b806725

	result.alternateText = ReportUtils.formatReportLastMessageText(getWelcomeMessage(report, policy).messageText ?? Localize.translateLocal('report.noActivityYet'));
	}

What changes do you think we should make in order to solve the problem?

We need to set alternateText to the getReportActionMessageText of the lastAction if the last action type is POLICY_CHANGE_LOG.DELETE_CUSTOM_UNIT_RATE (FYI: That is how the report action is displayed in report action item) here

else if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_CUSTOM_UNIT_RATE) {
            result.alternateText = ReportActionsUtils.getReportActionMessageText(lastAction) ?? '';
        } 

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016424eee2de4a22ba

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)