[OldDot Rules Migration] Category Rules

[marcaaron]

Part of the OldDot Rules Migration project

Main issue: https://github.com/Expensify/Expensify/issues/413886

Feature Description

![2024-08-07_14-40-16]

(https://github.com/user-attachments/assets/dba5b219-9d51-4935-909f-ce17e635bdb0)

High Level Section: https://docs.google.com/document/d/1oLr14YhL6Y0N5g4tbozdIIrFbybBlsRA0H9I8Wm--w8/edit#bookmark=id.dk0p2mr4zxie

Detailed Section: https://docs.google.com/document/d/1oLr14YhL6Y0N5g4tbozdIIrFbybBlsRA0H9I8Wm--w8/edit#bookmark=id.dk0p2mr4zxie

Manual Test Steps

TBD

Automated Tests

TBD

Issue Owner

Current Issue Owner: @WojtekBoman

[WojtekBoman]

Hi! I'm going to work on this :)

[WojtekBoman]

@Expensify/design

I have one question about the Approver page.

I see we have a similar page in the workflows section and it looks like this:

Can the category and tag approver selection pages be implemented similarly this page?

I'm asking because I don't know if I should display the selected approver at the top of the page and the All section below.

[WojtekBoman]

@shawnborton @dannymcclain Could you take a look at it when you have some time? #47015 (comment)

[shawnborton]

Can the category and tag approver selection pages be implemented similarly this page?

I think the answer is yes, but only after there is an approver selected. Otherwise I assume we start off having no approver selected for those two things, and thus the list would not have anything at the top - it would just be a list of all available options.

Also, let's make sure we take a look at the updated flows for approvers as I think what you are showing is the "old" approval UI, right?

[dannymcclain]

I think the answer is yes, but only after there is an approver selected. Otherwise I assume we start off having no approver selected for those two things, and thus the list would not have anything at the top - it would just be a list of all available options.

Agree.

[WojtekBoman]

Also, let's make sure we take a look at the updated flows for approvers as I think what you are showing is the "old" approval UI, right?

Yes, when I was writing this question I didn't notice it had been updated :)

[WojtekBoman]

@marcaaron

I have a few questions about the category rules :)

1. On the Require receipts over page we should display policy?.maxExpenseAmount with policy?.outputCurrency for the default option, right? Is it appropriate to display $0 * Default if policy?.maxExpenseAmount is 0.
2. I'm wondering if we should use onyx optimistic data for updating the approver and default tax rate, because items that we store in policy?.rules?.expenseRules and policy?.rules?.approvalRules have own ids. Should I generate optimistic data manually on the frontend side without ids?