[HOLD for payment 2024-09-10][$250] [Search v2.1] Selected expense numbers are shown when logging in to another account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.18-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): dave0123seife@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Log into an account that have expenses
2. Click on search, found at the bottom
3. Select all the expenses, Notice the selected numbers are shown a the top
4. Log out from the account
5. Log back in with a different account
6. Go to search

Expected Result:

Selected number is not show

Actual Result:

Selected number of expenses of the previous account are shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6566633_1723204844051.IMG_3620.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0112a275318e1e1dc4
• Upwork Job ID: 1823627646288296373
• Last Price Increase: 2024-08-28
• Automatic offers:
• DylanDylann | Contributor | 103746189

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The selected expense in search page is persisted through different login.

What is the root cause of that problem?

The number of the selected expenses is coming from the search context provider.

App/src/components/Search/SearchPageHeader.tsx

Line 274 in db669c4

itemsLength={selectedTransactionsKeys.length}

App/src/components/Search/SearchPageHeader.tsx

Line 117 in db669c4

const {selectedTransactions, clearSelectedTransactions} = useSearchContext();

The search context provider is put at App.tsx.

App/src/App.tsx

Line 95 in db669c4

SearchContextProvider,

So, even when the user log out, the context data is still persisted.

What changes do you think we should make in order to solve the problem?

Move the SearchContextProvider to AuthScreen, just like OptionsListContextProvider.

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 355 to 356 in db669c4

	return (
	<OptionsListContextProvider>

What alternative solutions did you explore? (Optional)

Call clearSelectedTransactions when AuthScreens is unmounted.

[melvin-bot]

@kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0112a275318e1e1dc4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)