[HOLD for Payment 2024-09-06][$250] mWeb - Video - In welcome video, all playback speed options is not shown in normal mode

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.18
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Login as a Gmail account
3. In the Welcome Expensify video, tap 3 dots
4. Select playback speed
5. Note the number of playback speed options
6. Go to full screen mode
7. Tap 3 dots - playback speed
8. Note the number of playback speed options

Expected Result:

In the welcome video, all playback speed options shown is full screen mode must be shown in normal mode.

Actual Result:

In the welcome video, all playback speed options shown is full screen mode is not shown in normal mode.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6568733_1723364226029.Screenrecorder-2024-08-11-13-35-19-491_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014d75aeb575f9f1ea
• Upwork Job ID: 1823445367470479721
• Last Price Increase: 2024-08-13
• Automatic offers:
• ikevin127 | Reviewer | 103548572
• neonbhai | Contributor | 103548574

Issue Owner

Current Issue Owner: @ikevin127

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[IuliiaHerets]

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In welcome video, all playback speed options is not shown in normal mode

What is the root cause of that problem?

We are missing playback speeds that are offered by the native players

What changes do you think we should make in order to solve the problem?

We should add the missing playback speeds of 0.75 & 1.25 here

Result:

Video

Screen.Recording.2024-08-12.at.5.45.49.AM.mov

[daledah]

Edited by proposal-police: This proposal was edited at 2024-08-12 01:07:01 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In the welcome video, all playback speed options shown is full screen mode is not shown in normal mode.

What is the root cause of that problem?

The playback speed options shown in full screen mode contain [0.25, 0.5, 0.75, Normal, 1.25, 1.5, .175, 2] but in normal mode, it is just [0.25, 0.5, 1, 1.5, 2]:

App/src/CONST.ts

Line 4164 in 0341c3b

PLAYBACK_SPEEDS: [0.25, 0.5, 1, 1.5, 2],

App/src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx

Line 58 in 0341c3b

subMenuItems: CONST.VIDEO_PLAYER.PLAYBACK_SPEEDS.map((speed) => ({

What changes do you think we should make in order to solve the problem?

1. We need to add the missing playback speed value in normal mode:
   

   App/src/CONST.ts

   Line 4164 in 0341c3b

   PLAYBACK_SPEEDS: [0.25, 0.5, 1, 1.5, 2],

   
   will be:

        PLAYBACK_SPEEDS: [0.25, 0.5, 0.75, 1, 1.25, 1.5, 1.75, 2],

2. Update the initial playback speed:
   

   App/src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx

   Line 18 in 0341c3b

   const [currentPlaybackSpeed, setCurrentPlaybackSpeed] = useState<PlaybackSpeed>(CONST.VIDEO_PLAYER.PLAYBACK_SPEEDS[2]);

    const [currentPlaybackSpeed, setCurrentPlaybackSpeed] = useState<PlaybackSpeed>(CONST.VIDEO_PLAYER.PLAYBACK_SPEEDS[3]);

3. Optionally, with splayback speed value is 1, we can display Normal instead of 1 so it will be the same as what we did in fullscreen mode:
   

   App/src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx

   Line 60 in 0341c3b

   text: speed.toString(),

                text: speed !== 1 ?  speed.toString() : "Normal",

What alternative solutions did you explore? (Optional)

[daledah]

Proposal updated

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014d75aeb575f9f1ea

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)