[PAID] [$250] The preference setting doesn’t work when navigating between chat and settings.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.19-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @suneox
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1723478204237729

Action Performed:

1. Go to setting/preferences
2. Navigate to chat
3. Navigate back to setting tab
   (If issue doesn’t occur, try again few times)

Expected Result:

Setting animation should work and user can select option from preference setting.

Actual Result:

Setting animation doesn’t work and user can’t select option from preference setting.

This issue also happen on setting/security setting/about setting/Troubleshoot setting/Save the world

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-08-12.at.22.44.07.mp4

Recording.3154.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017fa6be05e532f86f
• Upwork Job ID: 1825658706975919362
• Last Price Increase: 2024-08-19
• Automatic offers:
• suneox | Contributor | 103646524
• QichenZhu | Contributor | 103646535

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[QichenZhu]

Edited by proposal-police: This proposal was edited at 2024-08-17 14:26:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pages with animated illustrations become unresponsive after switching to another page and back.

What is the root cause of that problem?

The root cause is similar to #36645 (comment).

When you switch to another page, the animated illustration keeps running in the background, adding tasks to a queue.

When you switch back, the browser has to process these tasks first, making it unresponsive to actions using the same queue, such as opening a right-side modal.

What changes do you think we should make in order to solve the problem?

Follow @hoangzinh's suggestion. The previous fix didn’t implement it because it wasn’t quite relevant to that issue, but it does resolve this issue.

Moreover, if we can combine useIsFocused and useAppState hooks, I think it would improve performance here.

App/src/components/Lottie/index.tsx

Line 36 in 7615898

if (isError || appState.isBackground || !animationFile || !isSplashHidden) {

import {useIsFocused} from '@react-navigation/native';

const isFocused = useIsFocused();
if (isError || !isFocused || appState.isBackground || !animationFile || !isSplashHidden) {

What alternative solutions did you explore? (Optional)

The drawback of the main solution is that the animated illustration disappears when the right-side modal is open. We can address this with the code below.

import {useNavigation} from '@react-navigation/native'
import NAVIGATORS from '@src/NAVIGATORS';

const [isHidden, setIsHidden] = React.useState(false);
const navigation = useNavigation();

React.useEffect(() => {
    const unsubscribe = navigation.addListener('focus', () => {
        setIsHidden(false);
    });
    return unsubscribe;
}, [navigation]);

React.useEffect(() => {
    const unsubscribe = navigation.addListener('blur', () => {
        const state = navigation.getState();
        if (state?.routes?.[state?.index ?? 0]?.name !== NAVIGATORS.RIGHT_MODAL_NAVIGATOR) {
            setIsHidden(true);
        }
    });
    return unsubscribe;
}, [navigation]);

if (isError || isHidden || appState.isBackground || !animationFile || !isSplashHidden) {

[strepanier03]

Confirmed this occurred on v9.0.22-5 after 3 tries.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017fa6be05e532f86f