[HOLD for payment 2024-10-10] [Report next steps audit] Next step in report header changes after returning online

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.19.2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #44940

Action Performed:

precondition: create a control workspace, set "Manually approve all expenses" over to $10 and set advanced approval in OD:
boss owner (admin) submits to mini owner
mini owner (admin) submits boss owner
manager (employee) submits to mini owner forwards to mini owner over limit forwards (limit 100) to boss owner
employee 1 (employee) submits to manager
employee 2(employee) submits to manager

1. Log in as an employee 1
2. Disable the internet connection
3. Submit an expense below $100
4. Return online and observe the next step in report header
5. Log in as an manager
6. Approve the report
7. Log in as mini owner
8. Disable the internet connection
9. Approve the report
10. Return online

Expected Result:

The same next step in report header displayed offline and online: for step 4 it is "Waiting for Manager approve expense(s)", and for step 10 it is "No further action required!"

Actual Result:

When user returns online, the next step in report header changes from "Waiting for Manager approve expense(s)" to "Waiting for employee 1 submit their expense (s)" for step 4 and from "Waiting for Boss owner pay expense(s) to "No further action required!" for step 4

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6570207_1723486899933.Recording__667.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[trjExpensify]

Put on the radar of @dylanexpensify @dangrous and co here as it's in dev, checking if these are internal or not: https://expensify.slack.com/archives/C06ML6X0W9L/p1723559615613289?thread_ts=1723491174.174309&cid=C06ML6X0W9L

[dangrous]

Okay I just tried replicating this - I'm not getting the same notes - for the step 4 one, I get waiting for expenses to automatically submit later today which I think is correct, so I don't think there's an issue there?

For step 10, I'm getting "no further action required" from the backend so that should be updated.

[dangrous]

Huh this is much more complicated than I thought on the backend. I've made a draft PR but struggling with some pieces, I will come back to it later.

It sounds like from Slack that this is okay to punt a little, since we're not holding on it for the end of the project (seems like a bug that existed before).

[dangrous]

Progress is being made! The trick here is that I think the existing tests were incorrect. I've pushed a fix to the linked PR, and I think we should be moving shortly, assuming @mountiny agrees with the changes I've made (which honestly I'm not confident on)