[HOLD for payment 2024-08-29] [$250] Workspace - ESC key does not dismiss popup in Distance rates

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.20-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Access staging.new.expensify.com OR open the New Expensify staging app
2. Sign into a valid account
3. Click on Profile > WS > Distance rates > Try to delete the only Distance rate available to get the popup to show
4. Click "Esc" on the Devices Keyboard

Expected Result:

User expects the popup to close when clicking ESC

Actual Result:

The popup does not close

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6572169_1723652004816.ESC_key_does_not_close_popup.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011e64fa845f9a1a48
• Upwork Job ID: 1824492143153365080
• Last Price Increase: 2024-08-16
• Automatic offers:
• ahmedGaber93 | Reviewer | 103590268
• Krishna2323 | Contributor | 103590270

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-08-14 17:23:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - ESC key does not dismiss popup in Distance rates

What is the root cause of that problem?

onCancel prop is not passed to ConfirmModal.

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Lines 337 to 344 in ed689fa

	<ConfirmModal
	onConfirm={() => setIsWarningModalVisible(false)}
	isVisible={isWarningModalVisible}
	title={translate('workspace.distanceRates.oopsNotSoFast')}
	prompt={translate('workspace.distanceRates.workspaceNeeds')}
	confirmText={translate('common.buttonConfirm')}
	shouldShowCancelButton={false}
	/>

What changes do you think we should make in order to solve the problem?

Pass onCancel prop as onCancel={() => setIsWarningModalVisible(false)}.

We should also check in other components for similar issue.

What alternative solutions did you explore? (Optional)

[codewaseem]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When ESC key is pressed the Modal doesn't close.

What is the root cause of that problem?

The onCancel handler is not set on this modal.

What changes do you think we should make in order to solve the problem?

Simply setting the onCancel handler will fix this issue.

What alternative solutions did you explore? (Optional)

None

[Christinadobrzyn]

It does look like ESC should work to close these popup windows in other areas of the workspace so I think we do need to fix this. I can reproduce. Adding an external label to review the proposals.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011e64fa845f9a1a48

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[Krishna2323]

@ahmedGaber93, friendly bump for review.