Chat - Unread marker moves to first message sent offline when returning online

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.20.6
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR #47393
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/ and log in
2. Open any chat
3. Disable the internet connection
4. Send a few message
5. Mark any message unread, but not the first one that was sent
6. Enable the internet connection

Expected Result:

The unread marker stays above the message that was selected unread

Actual Result:

The unread marker moves up to the first message that was sent while offline

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6572560_1723686265041.Recording__684.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The unread marker moves up to the first message that was sent while offline

What is the root cause of that problem?

When we mark as unread an action offline, unreadMarkerTime is assigned as the client's created time of the action. Then when we online, BE returns the db created time of the action that is more than the client's created time. So the unread marker is moved up.

App/src/pages/home/report/ReportActionsList.tsx

Line 213 in 57ef25c

const [unreadMarkerTime, setUnreadMarkerTime] = useState(report.lastReadTime ?? '');

What changes do you think we should make in order to solve the problem?

We should update shouldDisplayNewMarker function to check if we already have an unread marker action we only check the reportActionID is matched with unreadMarkerReportActionID or not

if (!unreadMarkerReportActionID) {
    // the current logic
} else {
    return reportAction.reportActionID === unreadMarkerReportActionID
}

App/src/pages/home/report/ReportActionsList.tsx

Line 225 in 57ef25c

const shouldDisplayNewMarker = (reportAction: OnyxTypes.ReportAction, index: number): boolean => {

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.