[HOLD for Payment 2024-10-04][$250] Update UpdatePolicyConnectionConfiguration to be 1:1:1 - Part 4 #47522
Description
Problem
Our UpdatePolicyConnectionConfiguration API command is not 1:1:1 - it is the same API call for all related user actions, when it should be split up for each connection (QBO, Xero, etc.) and configuration setting (autoSyncVendor, enableNewCategories, etc.). At the end of this we should not call that function anywhere.
This is polish for the Collect QBO project.
Solution
When we created the NetSuite commands, we followed the correct pattern, and so need to do so here too.
This requires backend and frontend work in tandem (to create the commands and then to use them), so we're looking for a contributor(s) to handle the frontend. You can see an example PR here - there is some extra prep work there that you can ignore, but adjusting all calls like this is what we're going for:
- Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT, row.value);
+ QuickbooksOnline.updateQuickbooksOnlineReimbursableExpensesAccount(policyID, row.value);Here is a list of the commands handled in this issue:
- UpdateQuickbooksOnlineAutoSync
- UpdateQuickbooksOnlineSyncPeople
- UpdateQuickbooksOnlineReimbursementAccountID
- UpdateQuickbooksOnlineExport - We will need to split up this one even further, one for each piece of the object that it is updating. We can discuss this on the PRs.
If there are others that follow the same pattern as UpdateQuickbooksOnlineExport (same object, different keys) we will need to split those as well.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01eef0bc66034bca70
- Upwork Job ID: 1825578317140040932
- Last Price Increase: 2024-08-19
- Automatic offers:
- shubham1206agra | Contributor | 103590186