[Awaiting payment some time in the past] [$250] Workspace switcher - Empty workspace switcher does not have "Create a workspace" modal

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.21-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new account (account must have no workspace)
3. Open workspace switcher

Expected Result:

The empty workspace switcher will have "Create a workspace" modal

Actual Result:

The empty workspace switcher does not have "Create a workspace" modal

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6573290_1723753657422.20240816_042526.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01720ac33ff733e428
• Upwork Job ID: 1824216428360268213
• Last Price Increase: 2024-08-15
• Automatic offers:
• dukenv0307 | Reviewer | 103545556
• Krishna2323 | Contributor | 103545557

Issue Owner

Current Issue Owner: @dukenv0307

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[Krishna2323]

Regression from #42413

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace switcher - Empty workspace switcher does not have "Create a workspace" modal

What is the root cause of that problem?

WorkspaceSwitcherPage uses listFooterContent to render WorkspaceCardCreateAWorkspaceInstance but the selection list is not rendered when the list is empty.

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 696 to 701 in 5b83a4b

	{flattenedSections.allOptions.length === 0 ? (
	renderListEmptyContent()
	) : (
	<>
	{!listHeaderContent && header()}
	<SectionList

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 478 to 486 in 5b83a4b

	const renderListEmptyContent = () => {
	if (showLoadingPlaceholder) {
	return <OptionsListSkeletonView shouldStyleAsTable={shouldUseUserSkeletonView} />;
	}
	if (shouldShowListEmptyContent) {
	return listEmptyContent;
	}
	return null;
	};

What changes do you think we should make in order to solve the problem?

• We should use listEmptyContent={WorkspaceCardCreateAWorkspaceInstance} & shouldShowListEmptyContent={shouldShowCreateWorkspace} props.
• We should also check for other components which uses listFooterContent and listEmptyContent.

What alternative solutions did you explore? (Optional)

Result

Monosnap.screencast.2024-08-16.02-59-50.mp4

[yuwenmemon]

@Krishna2323 LGTM, thanks for identifying the regression as well. cc @tienifr

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01720ac33ff733e428

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)