[HOLD for Payment 2024-09-06][$250] Add bank account flow has too much padding below bottom button

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.21-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1723725008039179

Action Performed:

1. Go to workspace
2. Add bank account
3. Continue to step 2 personal page
4. Observe the padding below the Next button

Expected Result:

They should just have 20px padding on the left/right/bottom

Actual Result:

All of the bottom docked buttons have too much padding below them

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016d5ff6180f00c2d9
• Upwork Job ID: 1825648516021828712
• Last Price Increase: 2024-08-19
• Automatic offers:
• ikevin127 | Reviewer | 103620843
• cretadn22 | Contributor | 103620845

Issue Owner

Current Issue Owner: @ikevin127

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[cretadn22]

Edited by proposal-police: This proposal was edited at 2024-08-16 15:52:37 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add bank account flow has too much padding below bottom button

What is the root cause of that problem?

App/src/pages/ReimbursementAccount/PersonalInfo/substeps/Address.tsx

Line 77 in 279f561

submitButtonStyles={[styles.mb0, styles.pb5]}

We added bottom padding to this button.

What changes do you think we should make in order to solve the problem?

Let's remove the bottom padding.

To maintain consistency, we should also remove the bottom padding from the submit button on other forms.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016d5ff6180f00c2d9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[ikevin127]

♻️ Reviewing existing proposal.