[PAY 2ND SEP][$250] Deeplink [Desktop] - Copied conversation URL opens another chat

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.22-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2661801
Issue reported by: Applause Internal Team

Action Performed:

Precondition: user is logged out from desktop app.

1. Copy conversation URL in browser
2. Log out from web app
3. Paste copied URL in browser
4. Login
5. Click 'Open New Expensify' in popup

Expected Result:

User is logged in desktop app. User is navigated to conversation from step 1.

Actual Result:

User is logged in desktop app. User is navigated to recent conversation.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6566514_1723196462739.deeplink_desktop.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d5253a8417e4f6c4
• Upwork Job ID: 1825698104047606394
• Last Price Increase: 2024-08-20
• Automatic offers:
• c3024 | Reviewer | 103603686
• nkdengineer | Contributor | 103603687

Issue Owner

Current Issue Owner: @c3024

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[IuliiaHerets]

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[jliexpensify]

Can repro, only occurs with the Desktop app. Opening the URL in Chrome works fine.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d5253a8417e4f6c4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is logged in desktop app. User is navigated to recent conversation.

What is the root cause of that problem?

When we login, the desktop prompt is shown immediately after we sign in.

App/src/components/DeeplinkWrapper/index.website.tsx

Line 29 in 6334d36

App.beginDeepLinkRedirect(!isMagicLink);

So at the time, the prompt appears and the URL is set, window.location.pathname is the default URL. Then after we redirect to the desktop app the most recent report is opened that isn't the report that we opened via deeplink on the web.

App/src/libs/Browser/index.website.ts

Line 87 in 6334d36

params.set('exitTo', `${openingFromDesktopRedirect ? '/r' : window.location.pathname}${window.location.search}${window.location.hash}`);

What changes do you think we should make in order to solve the problem?

We already have a state to store the initialUrl here. We should pass this on to DeeplinkWrapper. We will use getInternalNewExpensifyPath to get the internal route from initialUrl and then pass it from promptToOpenInDesktopApp to openRouteInDesktopApp

App/src/Expensify.tsx

Lines 215 to 218 in 6334d36

	Linking.getInitialURL().then((url) => {
	setInitialUrl(url);
	Report.openReportFromDeepLink(url ?? '');
	});

Then here we will use the initial route to set the exitTo param if it exists

App/src/libs/Browser/index.website.ts

Line 87 in 6334d36

params.set('exitTo', `${openingFromDesktopRedirect ? '/r' : window.location.pathname}${window.location.search}${window.location.hash}`);

What alternative solutions did you explore? (Optional)

Result