[$250] Tags - System message for disabling, adding tax code and deleting X: Y tag shows X\: Y tag

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace is under Control plan.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Tags
3. Add a tag in X: Y format
4. Disable, add tax code and delete the tag in X:Y format
5. Go to #admins

Expected Result:

The system message for disabling, adding tax code and deleting tag in X: Y format will display the tag correctly

Actual Result:

The system message for disabling, adding tax code and deleting tag in X: Y format displays the tag in X: Y format

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6578196_1724248326940.bandicam_2024-08-21_21-43-35-544.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e7a0584538b48c5f
• Upwork Job ID: 1826803032920988282
• Last Price Increase: 2024-08-23

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2024-08-21 23:08:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The system message for disabling, adding, and deleting the X: Y tag displays as "X: Y tag."

What is the root cause of that problem?

The comment message is only cleaned and parsed when the tag is added, but not when it is updated or deleted.

App/src/pages/home/report/ReportActionItem.tsx

Lines 652 to 654 in f80d19b

	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_TAG) {
	children = <ReportActionItemBasicMessage message={PolicyUtils.getCleanedTagName(ReportActionsUtils.getReportActionMessage(action)?.text ?? '')} />;
	} else if (

What changes do you think we should make in order to solve the problem?

We should add conditions for the remove, disable, enable, and update actions, as well as any other actions that display the tag name in the comment.

} else if (
            action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_TAG ||
            action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_TAG_ENABLED ||
            action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_TAG_NAME ||
            action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_TAG ||
            action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_TAG
        ) {

we can also add other actions that show the tag name in the comment

And as daledah mentioned we need to do the same in the sideBar as well since the same problem also shown in the LHN data ... so the same fix would be applied here as well
App/src/libs/SidebarUtils.ts
Result:

What alternative solutions did you explore? (Optional)

N/A

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• In LHN and report page, the system message for disabling, adding tax code and deleting tag in X: Y format displays the tag in X: Y format.

What is the root cause of that problem?

• In LHN, we do not convert X: Y to X\: Y in case of system message for disabling, updating tag:
  

  App/src/libs/SidebarUtils.ts

  Lines 428 to 430 in ad7c1d5

  	} else if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_TAG) {
  	result.alternateText = PolicyUtils.getCleanedTagName(ReportActionsUtils.getReportActionMessage(lastAction)?.text ?? '');
  	} else if (lastAction && ReportActionsUtils.isOldDotReportAction(lastAction)) {

• The same issue when displaying report actions:
  

  App/src/pages/home/report/ReportActionItem.tsx

  Lines 657 to 659 in ad7c1d5

  	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_TAG) {
  	children = <ReportActionItemBasicMessage message={PolicyUtils.getCleanedTagName(ReportActionsUtils.getReportActionMessage(action)?.text ?? '')} />;
  	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_NAME) {

What changes do you think we should make in order to solve the problem?

• We should create a function to check whether the action is needed to clean the tag name:

const isActionNeedToCleanup(actionName: string) {
    return [CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_TAG, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_TAG, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_TAG_ENABLED, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_TAG, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_TAG_NAME].includes(actionName)
}

• Then:
  

  App/src/libs/SidebarUtils.ts

  Line 428 in ad7c1d5

  } else if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_TAG) {

  
  will be:

        } else if (isActionNeedToCleanup(lastAction?.actionName)) {

• And:
  

  App/src/pages/home/report/ReportActionItem.tsx

  Line 657 in ad7c1d5

  } else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_TAG) {

  
  will be:

        } else if (isActionNeedToCleanup(action?.actionName)) {

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e7a0584538b48c5f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)