[$250] Web - Attachment - "Worker was terminated" console error when closing a PDF

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4880362&group_by=cases:section_id&group_id=292107&group_order=asc
Issue reported by:

Action Performed:

1. Navigate to https://staging.new.expensify.com/

2. Log in with a new Gmail account

3. Navigate to FAB - Start chat

4. Start a 1:1 DM with any account

5. Upload a small PDF (included)

6. Upload a large PDF (included)

7. Open the large PDF

8. Close the large PDF

9. Open the small PDF

10. Close the small PDF

Expected Result:

I should be able to close the PDF without a console error.

Actual Result:

"Worker was terminated" console error when closing a PDF after opening and closing a different, larger PDF. Sometimes I get the console error when closing an image attachment too.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6578472_1724261778978.bandicam_2024-08-21_19-25-00-639.mp4

Bug6578472_1724261778945!Small_PDF.pdf
Bug6578472_1724261778936!Large_PDF.pdf

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a5b10381ea8600ab
• Upwork Job ID: 1827398804771215994
• Last Price Increase: 2024-08-24
• Automatic offers:
• paultsimura | Reviewer | 103709560

Issue Owner

Current Issue Owner: @paultsimura

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[andriivitiv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Worker was terminated" console error shows up when closing a PDF view while it is still loading.

What is the root cause of that problem?

This error occurs because loadingTask.destroy() is not working correctly, as explained in mozilla/pdf.js#11595.

We previously fixed this issue in #31209, but it has reappeared since. The reason is that the previous fix patches the node_modules/react-pdf/dist/esm/Document.js file, but the app now uses node_modules/react-pdf/dist/cjs/Document.js.

What changes do you think we should make in order to solve the problem?

In addition to the esm/Document.js file, we need to apply the same fix to cjs/Document.js.

Updated react-pdf+7.7.3.patch file will be:

diff --git a/node_modules/react-pdf/dist/cjs/Document.js b/node_modules/react-pdf/dist/cjs/Document.js
index 9bb0398..032d898 100644
--- a/node_modules/react-pdf/dist/cjs/Document.js
+++ b/node_modules/react-pdf/dist/cjs/Document.js
@@ -289,6 +289,7 @@ const Document = (0, react_1.forwardRef)(function Document(_a, ref) {
             pdfDispatch({ type: 'REJECT', error });
         });
         return () => {
+            loadingTask._worker.destroy();
             loadingTask.destroy();
         };
     }
diff --git a/node_modules/react-pdf/dist/esm/Document.js b/node_modules/react-pdf/dist/esm/Document.js
index b1c5a81..569769e 100644
--- a/node_modules/react-pdf/dist/esm/Document.js
+++ b/node_modules/react-pdf/dist/esm/Document.js
@@ -261,6 +261,7 @@ const Document = forwardRef(function Document(_a, ref) {
             pdfDispatch({ type: 'REJECT', error });
         });
         return () => {
+            loadingTask._worker.destroy();
             loadingTask.destroy();
         };
     }

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a5b10381ea8600ab

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)