[$250] clicking on a chat row in a thread within a thread leads to "not found" page.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.24-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724336539348799

Action Performed:

1. Initiate a chat
2. Reply in the thread
3. Reply in the thread of thread
4. Click on the chat row in a thread within the thread

Expected Result:

Able to open the chat

Actual Result:

Leads to "not found" page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.488.mp4

Screen.Recording.2024-08-22.at.10.21.33.AM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b2e4f856351af3b6
• Upwork Job ID: 1828188239764165076
• Last Price Increase: 2024-08-26
• Automatic offers:
• brunovjk | Reviewer | 103719086

Issue Owner

Current Issue Owner: @brunovjk

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Edited by proposal-police: This proposal was edited at 2024-08-23 03:21:15 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

1. Press a thread ancestor leads to "not found" page
2. The first thread ancestor is not pressable

What is the root cause of that problem?

We're using parentReportID from these ancestors:

App/src/pages/home/report/ReportActionItemParentAction.tsx

Lines 128 to 141 in caab39b

	onPress={
	ReportUtils.canCurrentUserOpenReport(ancestorReports.current?.[ancestor?.report?.parentReportID ?? '-1'])
	? () => {
	const isVisibleAction = ReportActionsUtils.shouldReportActionBeVisible(ancestor.reportAction, ancestor.reportAction.reportActionID ?? '-1');
	// Pop the thread report screen before navigating to the chat report.
	Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(ancestor.report.parentReportID ?? '-1'));
	if (isVisibleAction && !isOffline) {
	// Pop the chat report screen before navigating to the linked report action.
	Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(ancestor.report.parentReportID ?? '-1', ancestor.reportAction.reportActionID));
	}
	Timing.start(CONST.TIMING.SWITCH_REPORT);
	}
	: undefined
	}

which leads us up to 1 level higher.

Because the report data in these ancestors already points to its parent report:

App/src/libs/ReportUtils.ts

Line 7175 in ed910fa

report: parentReport,

What changes do you think we should make in order to solve the problem?

Use reportID instead of parentReportID.

[melvin-bot]

@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b2e4f856351af3b6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)