[HOLD for payment 2024-09-19] [$250] Tags - App closes RHP after upgrade and clicking back button in GL code page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.25-10
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a Collect workspace.
3. Go to Categories.
4. Click on any category > GL code/Payroll code.
5. Click Upgrade > Click Got it, thanks.
6. On the code editor page, click on the app back button.
7. Note that app returns to category details RHP.
8. Create a Collect workspace.
9. Go to Tags.
10. Add a tag > Click on tag > GL code.
11. Click Upgrade > Click Got it, thanks.
12. On the code editor page, click on the app back button.

Expected Result:

App will return to tag details RHP after upgrade and clicking back button in GL code page.

Actual Result:

App closes RHP after upgrade and clicking back button in GL code page.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6585134_1724841637865.20240828_183542.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b3d86efe655bb313
• Upwork Job ID: 1829329439413113957
• Last Price Increase: 2024-08-30
• Automatic offers:
• ZhenjaHorbach | Reviewer | 103806540
• Krishna2323 | Contributor | 103806542

Issue Owner

Current Issue Owner: @ZhenjaHorbach

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2023-10-17T11:45:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tags - App closes RHP after upgrade and clicking back button in GL code page

What is the root cause of that problem?

We aren't passing the fallback route to goBack.

App/src/pages/workspace/tags/TagGLCodePage.tsx

Line 68 in 392da13

onBackButtonPress={() => Navigation.goBack()}

What changes do you think we should make in order to solve the problem?

• Pass ROUTES.WORKSPACE_TAG_SETTINGS.getRoute(route.params.policyID, orderWeight, tagName) as the fallback route to the goBack function.
• We should also look for similar inconsistencies and should fix those as well.

What alternative solutions did you explore? (Optional)



Result

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2023-10-11T13:45:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App closes RHP after upgrade and clicking back button in GL code page

What is the root cause of that problem?

• The fallback route is not passed to the goBack function in this

  App/src/pages/workspace/tags/TagGLCodePage.tsx

  Line 68 in 392da13

  onBackButtonPress={() => Navigation.goBack()}

• To resolve this, we should apply the same goBack logic in the submit logic

What changes do you think we should make in order to solve the problem?

• To ensure consistency, since the back behavior is the same for both the submit and back buttons, we should create a goBack function and use it in both locations instead of duplicating the code.
• This approach should also be applied to the CategoryPayrollCodePage.

What alternative solutions did you explore? (Optional)

N.A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b3d86efe655bb313

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)