[$250] Android - QAB - In mWeb, merchant shown as "expense"&in Android unexpected error for QAB expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.25
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4898411
Issue reported by: Applause Internal Team

Action Performed:

1. Launch site in both mweb and Android app
2. Tap fab -- submit an expense
3. Tap tab -- via QAB submit an expense
4. In mweb, open both expense and for Android wait few seconds

Expected Result:

With any inconsistency and error user must be able to submit expense via QAB.

Actual Result:

In mweb, merchant shown as "expense" in QAB via createe expense. In Android, QAB via created expense shows unexpected error.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6585120_1724841105617.sub.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01095a4da6e8b969c0
• Upwork Job ID: 1830537395505788792
• Last Price Increase: 2024-09-02
• Automatic offers:
• nkdengineer | Contributor | 103901378

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[andriivitiv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant is shown as "Expense" if the expense was created via the "Quick action" button

What is the root cause of that problem?

Expense created via FAB > Submit expense has the merchant property set to CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT.

Expense created via FAB > Quick action > Submit expense has the merchant property set to CONST.TRANSACTION.DEFAULT_MERCHANT.

Then in MoneyRequestView we decide whether the merchant name should be shown

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 166 in 3d8ee65

const isEmptyMerchant = transactionMerchant === '' || transactionMerchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT;

What changes do you think we should make in order to solve the problem?

We need to add a check for CONST.TRANSACTION.DEFAULT_MERCHANT similar to how it's done in other places

diff --git a/src/components/ReportActionItem/MoneyRequestView.tsx b/src/components/ReportActionItem/MoneyRequestView.tsx
index 57c5c01da55..d2860bbd0fb 100644
--- a/src/components/ReportActionItem/MoneyRequestView.tsx
+++ b/src/components/ReportActionItem/MoneyRequestView.tsx
@@ -163,7 +163,10 @@ function MoneyRequestView({
         originalAmount: transactionOriginalAmount,
         originalCurrency: transactionOriginalCurrency,
     } = useMemo<Partial<TransactionDetails>>(() => ReportUtils.getTransactionDetails(transaction) ?? {}, [transaction]);
-    const isEmptyMerchant = transactionMerchant === '' || transactionMerchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT;
+    const isEmptyMerchant =
+        transactionMerchant === '' ||
+        transactionMerchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT ||
+        transactionMerchant === CONST.TRANSACTION.DEFAULT_MERCHANT;
     const isDistanceRequest = TransactionUtils.isDistanceRequest(transaction);
     const formattedTransactionAmount = transactionAmount ? CurrencyUtils.convertToDisplayString(transactionAmount, transactionCurrency) : '';
     const formattedOriginalAmount = transactionOriginalAmount && transactionOriginalCurrency && CurrencyUtils.convertToDisplayString(transactionOriginalAmount, transactionOriginalCurrency);

[andriivitiv]

My proposal doesn't cover the error on android part as it is being fixed in #45086

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01095a4da6e8b969c0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)