[HOLD for Payment 2024-09-24][$250] Invoice - Default workspace avatar is displayed for invoice receiver when it has custom avatar

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.26-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4864174
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace has custom avatar.

1. Go to staging.new.expensify.com
2. Go to FAB > Send invoice.
3. Enter amount. select user and send invoice.
4. As invoice receiver, go to invoice chat.

Expected Result:

Invoice receiver should be able to see the custom workspace avatar.

Actual Result:

Invoice receiver is unable to see the custom workspace avatar. It shows the default avatar instead.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6573880_1723822556534.20240816_233027.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014c6b9826c08600f4
• Upwork Job ID: 1830746639785190043
• Last Price Increase: 2024-09-09

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-bills

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Default workspace avatar is displayed for invoice receiver when it has custom avatar

What is the root cause of that problem?

Here we get the avatar from getWorkspaceAvatar

App/src/pages/home/report/ReportActionItemSingle.tsx

Line 103 in 04ffa6c

avatarSource = ReportUtils.getWorkspaceAvatar(report);

and in here the avatar URL will be empty and it will fallback to workspace default avatar

App/src/libs/ReportUtils.ts

Line 1856 in 04ffa6c

const avatar = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.avatarURL ?? '';

What changes do you think we should make in order to solve the problem?

We need to change this line

App/src/libs/ReportUtils.ts

Line 1856 in 04ffa6c

const avatar = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.avatarURL ?? '';

We have avatar stored in report?.policyAvatar we can do something like this. This is the same way we are getting avatar here. This is why we don't see this problem in header.

    const avatar =report?.policyAvatar ||  allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.avatarURL ;

What alternative solutions did you explore? (Optional)

We can use this function to get workspace icons in ReportActionItemSingle.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mallenexpensify]

Unable to reproduce, throwing a retest on here

[Nodebrute]

@mallenexpensify Hey, it's reproducible on the latest main branch.

[mallenexpensify]

I tested on v9.0.26-6 and this issue was reported with Version Number: v9.0.26-5
@Nodebrute , can you outline your reproduction steps? Reckon one of us is doing something different than the other.

[Nodebrute]

@mallenexpensify Here are the steps I followed (v9.0.27-0)

1. Have a workspace with a picture.
2. Go to FAB -> Send Invoice.
3. Send the invoice to a 1:1 DM.
4. For the invoice receiver, it shows the default avatar in the message.

Screen.Recording.2024-08-31.at.5.25.52.AM.1.mov