[$250] Company cards - App crashes when enabling “Allow deleting transactions”

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.28-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Company cards
3. Tap Settings.
4. Enable “Allow deleting transactions”.

Expected Result:

App will not crash after enabling “Allow deleting transactions”.

Actual Result:

App crashes after enabling “Allow deleting transactions”.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

0309.txt

Bug6591350_1725347264460.20240903_150656.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0177bfb8694e7ac7da
• Upwork Job ID: 1830944843037262347
• Last Price Increase: 2024-09-03
• Automatic offers:
• ZhenjaHorbach | Contributor | 103795111

Issue Owner

Current Issue Owner: @Pujan92

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-09-03 12:04:52 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

Company cards - App crashes when enabling “Allow deleting transactions”

What is the root cause of that problem?

We aren't using optional chaining when accessing lastSelectedFeed property.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsSettingsPage.tsx

Lines 43 to 44 in aa69371

	const feedName = cardFeeds?.companyCardNicknames[lastSelectedFeed] ?? '';
	const liabilityType = cardFeeds?.companyCards[lastSelectedFeed]?.liabilityType;

What changes do you think we should make in order to solve the problem?


Add ?.

What alternative solutions did you explore? (Optional)

Update to:

    const feedName = cardFeeds?.companyCardNicknames?.[lastSelectedFeed] ?? '';
    const liabilityType = cardFeeds?.companyCards?.[lastSelectedFeed]?.liabilityType;

• Same needs to be done in WorkspaceCompanyCardsSettingsFeedNamePage.

Result

[narefyev91]

I will take care of it, but generally company cards feature is in development phase and its under beta feature flag