[$250] Expense report-Submit & approve button not disappear until page refreshed

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.28.0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validation PR: #48362
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: log into OD as an admin, create a control policy, enable workspace chats, select "Advanced Approvals", invite 3 members (non-admin): 2 approvers and 1 submitter, set the approval flow as submitter submits to approver 1

1. Log into ND as submitter
2. Navigate to the workspace chat
3. Submit one manual expense
4. Open the report and click on the "Submit" button
5. As admin, change the the submitter's submitsTo to approver 2 in OD
6. Log into ND as approver 1
7. Opened the submitted report
8. Click on the "Approve" button

Expected Result:

The 'Submit" button disappears immediately for the submitter (step 4) and the "Approve" button disappears for the approver (step 8)

Actual Result:

The "Submit" and "Approve" button do not disappear until the page is refreshed or it is clicked on the second time (the "Approve" button)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6591339_1725333837619.Recording__737.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01efec68070b933fc3
• Upwork Job ID: 1831071506567798044
• Last Price Increase: 2024-10-29
• Automatic offers:
• nkdengineer | Contributor | 104649054

Issue Owner

Current Issue Owner:

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #wave-control

[izarutskaya]

Production

Recording.739.mp4

Recording.2788.mp4

[srikarparsi]

Looked into this and I think this might be a problem with manually submitting reports. I verified this by:

1. Creating a workspace
2. Setting the submit frequency to manual
3. Creating an expense
4. Submitting the expense
5. Seeing the submit button re-appear

(First part of the video is from staging and the second is from production)

manualSubmitBug.mov