[Payment due 8-18][$250] Group - Users with an external domain are displayed as Hidden in the group list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.27-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4909728
Email or phone of affected tester (no customers): sustinov@applausemail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Open NewExpensify app
2. Log in to the new HT account
3. Create a group chat with two users bob@domain.com
   and alice@domain.com
4. Open the list of members of the created group

Expected Result:

Users with an external domain should be displayed by email or name in a group list

Actual Result:

Users with an external domain are displayed as Hidden in the group list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6591417_1725344788657.RPReplay_Final1725280032.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0181038d02cba6971d
• Upwork Job ID: 1831023091657812719
• Last Price Increase: 2024-09-03
• Automatic offers:
• jjcoffee | Contributor | 103800323
• nkdengineer | Contributor | 103829257

Issue Owner

Current Issue Owner: @jjcoffee

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[mohamed-iyed-rhimi-1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users with an external domain should be displayed by email or name in a group list

What is the root cause of that problem?

The problem is here. If a participant does not have a displayName it defaults to the text "Hidden".

What changes do you think we should make in order to solve the problem?

We can simply check if the participant has either a displayName or an email ( eg: login ).
The new version will be :

let displayName = passedPersonalDetails?.displayName ?? passedPersonalDetails?.login ?? '';

What alternative solutions did you explore? (Optional)

Result:

[Christinadobrzyn]

I can reproduce this. This Hidden user has been going on for a while. I don't know if we have another GH related to resolving this - I don't see one. I'm assuming this is a BE fix but adding external for a C+ review first.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0181038d02cba6971d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)