[Payment due 2024-09-24][$250] Android - Room - For new user, invited member is shown with email but removed user shown as hidden

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.29
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Tap on a room chat
3. Tap header -- members -- invite
4. Go offline
5. Invite a new user with no expensify account eg : jaihanumanblog+festi@gmail.com
6. Then remove the user
7. Go online
8. Navigate to room conversation

Expected Result:

For new user, invited member is shown with email ig but removed user must not be shown as hidden.

Actual Result:

For new user, invited member is shown with email id but removed user shown as hidden

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6592594_1725435774312.Screenrecorder-2024-09-04-13-01-06-259_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834201133902466392
• Upwork Job ID: 1834201133902466392
• Last Price Increase: 2024-09-12

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The removed member system message shows Hidden.

What is the root cause of that problem?

When we invite an unknown user, we generate a random accountID for that user and if we add and delete it while offline, we send the random accountID to the delete request. The BE will eventually invite the user and return a newly created accountID for that user. We basically trying to delete the random accountID that doesn't exist on the BE, so the new member will show again on the list and the system message show Hidden because personal detail data for the random accountID is already cleared.

What changes do you think we should make in order to solve the problem?

We need to disable the item when it's an optimistic user, just like we did in #47686.

App/src/pages/RoomMembersPage.tsx

Lines 183 to 187 in c885f96

	const isDisabled =
	(isPolicyExpenseChat && isAdmin) ||
	accountID === session?.accountID ||
	pendingChatMember?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ||
	details.accountID === report.ownerAccountID;

|| details.isOptimisticPersonalDetail

We can apply the same fix on other pages if exist.

[melvin-bot]

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@kevinksullivan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834201133902466392

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)