[HOLD for payment 2024-10-17] [$250] Distance - Invalid waypoints aren't cleared when a request fails

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4919784
Email or phone of affected tester (no customers): testpayment935@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace
3. Go to workspace chat
4. Go offline
5. Go to submit distance expense
6. Enter an invalid waypoint and click save
7. Add another waypoint and continue to submit the expense
8. Go online
9. Verify the request fails
10. Green plus, submit an expense, distance
11. Go to enter a waypoint

Expected Result:

Invalid waypoints should be removed from suggestion list

Actual Result:

Invalid waypoints stay on the suggestion list

Workaround:

Submit a distance expense with valid waypoints, which will clear any invalid recent waypoints. Or. sign out and back in, since the invalid recent waypoints are only on the frontend.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-10-01.at.11.48.15.AM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833644939720857104
• Upwork Job ID: 1833644939720857104
• Last Price Increase: 2024-09-10
• Automatic offers:
• suneox | Reviewer | 104234581
• wildan-m | Contributor | 104234583

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[nyomanjyotisa]

Edited by proposal-police: This proposal was edited at 2024-09-05 11:08:41 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Invalid waypoint stays on suggestion list

What is the root cause of that problem?

We don't filter out the invalid waypoint from recentWaypoints here

What changes do you think we should make in order to solve the problem?

Filter out the invalid waypoint (the waypoint with lat and long equal to 0). Add the following filter to this selector

.filter((waypoint) => waypoint.lat !== 0 && waypoint.lng !== 0)

if we need to prevent selecting invalid waypoints when the network is offline we can change this and this to the following

        if (waypointValue !== '' && waypointAddress !== waypointValue) {
            ErrorUtils.addErrorMessage(errors, `waypoint${pageIndex}`, translate('distance.error.selectSuggestedAddress'));
        }

        hint={translate('distance.error.selectSuggestedAddress')}

What alternative solutions did you explore? (Optional)

Or we can just don't add the invalid waypoint to the recent waypoints here

if (!recentWaypointAlreadyExists && waypoint !== null && waypoint.lat !== 0 && waypoint.lng !== 0) {

[melvin-bot]

@johncschuster Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021833644939720857104

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)