[Awaiting Payment Sept 24th] [$125] Pay elsewhere missing as a payment method when configured for direct reimbursement on a workspace

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.29-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: #36301 (comment)

Action Performed:

1. Create a workspace
2. Go to More features > Enable Workflows
3. Go to Workflows > Enable approvals and payments
4. Click Connect bank account and add a VBBA
5. Submit an expense report on the workspace
6. Go to the expense report
7. Observe the Pay button

Expected Result:

The pay button should have an option to change it to Pay elsewhere to mark the report as manually reimbursed.

Actual Result:

The pay button does not have that option, only Pay $x using Expensify.

Workaround:

No

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831725635476300859
• Upwork Job ID: 1831725635476300859
• Last Price Increase: 2024-09-05
• Automatic offers:
• shubham1206agra | Contributor | 103842728

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831725635476300859

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Upwork job price has been updated to $125

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pay elsewhere missing as a payment method when configured for direct reimbursement on a workspace

What is the root cause of that problem?

The shouldShowPayElsewhereOption here is return false because both !isPaidGroupPolicy and policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_MANUAL are false

What changes do you think we should make in order to solve the problem?

we displaying the VBBA option if both isExpenseReport and shouldShowPaywithExpensifyOption are true

So add another condition on shouldShowPayElsewhereOption to show it if both isExpenseReport and shouldShowPaywithExpensifyOption are true

const shouldShowPayElsewhereOption = (!isPaidGroupPolicy || policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_MANUAL || (isExpenseReport && shouldShowPaywithExpensifyOption)) && !isInvoiceReport;

also we need to move the shouldShowPayElsewhereOption to inside paymentButtonOptions after isExpenseReport declaration

Result

What alternative solutions did you explore? (Optional)