[AWAITING PAYMENT] [$250] [OldDot Rules Migration] [Polish] - App freezes after updating Custom report name

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.31-12
Reproducible in staging?: Y
Reproducible in production?: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Create a new workspace.
3. Go to Workspace settings > Rules.
4. Enable Custom report names.
5. Tap Custom name.
6. Clear the field, enter anything and save it.
7. Try to scroll through the app.

Expected Result:

App will be responsive after updating Custom report name.

Actual Result:

App is freezing after updating Custom report name.
On web, app is responsive, but "Custom report names" and "Prevent members from changing custom report names toggles" are no longer working after updating Custom report name.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6598298_1725943845774.web.1.mp4

Bug6598298_1725943845758.Android.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021843814682618579436
• Upwork Job ID: 1843814682618579436
• Last Price Increase: 2024-10-09

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App freezes atter updating Custom report name

What is the root cause of that problem?

This error will only occur when we change the custom report names and areReportFieldsEnabled are false. When we call setPolicyDefaultReportTitle for the first time it's response also returns areReportFieldsEnabled:true which will cause the following condition to be true and in return this useEffect will run in loop causing the app to freeze on different devics

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 450 in 545f897

highlighted={enabledItem?.routeName === item.routeName}

What changes do you think we should make in order to solve the problem?

We can disable custom report names and tell user to go to more features and enable reportFields. We use this approach widely in our app

 title: translate('workspace.rules.expenseReportRules.customReportNamesTitle'),
            subtitle: policy?.areReportFieldsEnabled ? translate('workspace.rules.expenseReportRules.customReportNamesSubtitle') : renderFallbackSubtitle(translate('common.approvals').toLowerCase()),
            switchAccessibilityLabel: translate('workspace.rules.expenseReportRules.customReportNamesTitle'),
            isActive: policy?.shouldShowCustomReportTitleOption && policy?.areReportFieldsEnabled,
            disabled: !policy?.areReportFieldsEnabled,
            pendingAction: policy?.pendingFields?.shouldShowCustomReportTitleOption,

Note

This is just a pseudo-code example; other minor details can be addressed in the PR. We may also need to update the fallback subtitle content, so a revised version of that will be required.

What alternative solutions did you explore? (Optional)

We can optimistically set areReportFieldsEnabled to true if report fields are not enabled.

App/src/libs/actions/Policy/Policy.ts

Line 3973 in 286b945

value: {

Solution 3
We can check here if !policy?.areReportFieldsEnabled then we can call Policy.enablePolicyReportFields. We can do something like this

  onSubmit={({customName}) => {
                        if( !policy?.areReportFieldsEnabled){
                            Policy.enablePolicyReportFields(policyID, true, true)
                        }
                        PolicyActions.setPolicyDefaultReportTitle(policyID, customName);
                        Navigation.setNavigationActionToMicrotaskQueue(Navigation.goBack);
                    }}

[lakchote]

Not a blocker, it's behing beta BETA_WORKSPACE_RULES

cc @BrtqKr @marcaaron since you've worked on [OldDot Rules Migration] Expense report rules