[HOLD for payment 2024-10-10] [$250] Category rules - Approver field is blank for a moment after editing category name

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Rules and Workflows are enabled.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Categories.
3. Click on any category.
4. Click Approver.
5. Select any user.
6. Click Name.
7. Edit the name.

Expected Result:

Approver field will not go blank after editing category name.

Actual Result:

Approver field is blank for a moment after editing category name.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• [x ] iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6604525_1726418206489.20240916_003344.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021837011004719364383
• Upwork Job ID: 1837011004719364383
• Last Price Increase: 2024-09-20
• Automatic offers:
• FitseTLT | Contributor | 104131224

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-09-16 19:47:51 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Category rules - Approver field is blank for a moment after editing category name

What is the root cause of that problem?

We use category name to get the approver here

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Line 86 in 00bc167

const categoryApprover = CategoryUtils.getCategoryApprover(policy?.rules?.approvalRules ?? [], categoryName);

but the policy rule takes time to get updated with the new category name

What changes do you think we should make in order to solve the problem?

We can use previous category name to get a fallback in case the approver with current category name doesn't exist

const previousCategoryName = usePrevious(categoryName);

    const approverText = useMemo(() => {
        const categoryApprover = CategoryUtils.getCategoryApprover(policy?.rules?.approvalRules ?? [], categoryName);
        const prevApprover = CategoryUtils.getCategoryApprover(policy?.rules?.approvalRules ?? [], previousCategoryName);
        return categoryApprover ?? prevApprover ?? '';
    }, [categoryName, policy?.rules?.approvalRules]);

We also have an option to use previousCategoryName policyCategories to achieve the same similar to what we did here

const prev = Object.values(policyCategories ?? {}).find((category) => category.name === categoryName);
        const prevApprover = CategoryUtils.getCategoryApprover(policy?.rules?.approvalRules ?? [], prev?.previousCategoryName);
        return categoryApprover ?? prevApprover ?? '';

BTW similar problem exists for default tax rate which depends on policy?.rules?.expenseRules here so similar fix can be done for it too.

What alternative solutions did you explore? (Optional)

The other option we have is update policy?.rules?.approvalRules optimistically in Category.renamePolicyCategory on category name change. We can iterate on the approvalRules and when we find applyWhen with value prop same as the oldname of the category we change that value with the new category name (we will also optimistically update policy?.rules?.expenseRules for the problem regarding default tax rate)

[FitseTLT]

Updated

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021837011004719364383

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)