Task - Unassigned user can mark a task as incomplete

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.36-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #47519
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. [User A] Go to a DM with user B
2. [User A] Assign task to yourself
3. [User A] Mark it as complete
4. [User B] Open the task detail report
5. [User B] Click on header
6. [User B] Click Mark as incomplete button

Expected Result:

There shouldn't be 'Mark as complete button'

Actual Result:

Task is marked as uncompleted

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6605869_1726515386648.Screen_Recording_2024-09-16_at_10.26.52_at_night.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task - Unassigned user can mark a task as incomplete

What is the root cause of that problem?

In ReportDetails page, we are not checking if the current user is assignee or task owner before we are adding mark as incomplete action to menuItems

App/src/pages/ReportDetailsPage.tsx

Lines 369 to 374 in 6eb9396

	if (ReportUtils.isCompletedTaskReport(report) && canModifyTask) {
	items.push({
	key: CONST.REPORT_DETAILS_MENU_ITEM.MARK_AS_INCOMPLETE,
	icon: Expensicons.Checkmark,
	translationKey: 'task.markAsIncomplete',
	isAnonymousAction: false,

What changes do you think we should make in order to solve the problem?

We should check if the user is task assignee or task owner using Task.canActionTask

App/src/libs/actions/Task.ts

Lines 1154 to 1158 in 6eb9396

	* Check if you can change the status of the task (mark complete or incomplete). Only the task owner and task assignee can do this.
	*/
	function canActionTask(taskReport: OnyxEntry<OnyxTypes.Report>, sessionAccountID: number): boolean {
	return sessionAccountID === getTaskOwnerAccountID(taskReport) || sessionAccountID === getTaskAssigneeAccountID(taskReport);
	}

const canActionTask = Task.canActionTask(report, session?.accountID ?? -1);

 if (ReportUtils.isCompletedTaskReport(report) && canModifyTask && canActionTask)

What alternative solutions did you explore? (Optional)

[Krishna2323]

Proposal


Please re-state the problem that we are trying to solve in this issue.

• Task - Unassigned user can mark a task as incomplete

What is the root cause of that problem?

• We do not add canActionTask check when adding markAsIncomplete
  

  App/src/pages/ReportDetailsPage.tsx

  Lines 367 to 381 in 6eb9396

  	// Show actions related to Task Reports
  	if (isTaskReport && !isCanceledTaskReport) {
  	if (ReportUtils.isCompletedTaskReport(report) && canModifyTask) {
  	items.push({
  	key: CONST.REPORT_DETAILS_MENU_ITEM.MARK_AS_INCOMPLETE,
  	icon: Expensicons.Checkmark,
  	translationKey: 'task.markAsIncomplete',
  	isAnonymousAction: false,
  	action: Session.checkIfActionIsAllowed(() => {
  	Navigation.dismissModal();
  	Task.reopenTask(report);
  	}),
  	});
  	}
  	}

• The button to mark a task complete/incomplete in the report header is also not hidden.

What changes do you think we should make in order to solve the problem?


• We need to add canActionTask here and here.

What alternative solutions did you explore? (Optional)

Result

[CortneyOfstad]

We need to have a fall back in case a task is marked as complete by accident, giving someone the ability undo that (i.e. mark as incomplete).

The second person should have this option (especially if they are an admin on the default workspace), which these instructions are missing as a pre-requisite or not.

Closing!