New Library Request: react-native-bundle-splitter

[kirillzyusko]

In order to properly evaluate if a new library can be added to package.json, please fill out this request form. It will be automatically assigned someone from our review team that will go through and vet the library.

In order to add any new production dependency, it must be approved by the App Deployer team. They will evaluate the library and decide if it's something we want to move forward with or if other alternatives should be explored.

Note: This is only for production dependencies. While we don't want people to add packages to dev-dependencies willy-nilly, we recognize that there isn't as great of a need there to secure them.

Name of library:

Details

• Link to package: https://www.npmjs.com/package/react-native-bundle-splitter?activeTab=readme
• Problem solved by using this package: fix: abracadabra page #48899
• Number of stars in GH: 415
• Number of monthly downloads: 10557
• Number of releases in the last year: 2
• Level of activity in the repo: Low
• Alternatives: We can write a preloading mechanism ourself. It's just a matter of an additional code that will be present in Expensify codebase which we'll need to support.
• Are security concerns brought up and addressed in the library's repo? No
• How many dependencies does this lib use that will be brought into our code? 0
• What will the effect be on the bundle size of our code? Size of the package is 20kb, but bundle will be increased by ~11kb

[melvin-bot]

Triggered auto assignment to @grgia (AutoAssignerAppLibraryReview), see https://stackoverflowteams.com/c/expensify/questions/17737 for more details.

[melvin-bot]

New Library Review

• Are all the answers in the main description filled out properly and make sense?
• Who maintains the library and how well is it maintained?
• How viable are the alternatives?
• Should we build it ourselves instead?

Once these questions are answered, start a thread in #engineering-chat, ping the @app_deployers group, and call for a vote to accept the new library. Once the vote is complete, update this issue with the outcome and procede accordingly. Here is a sample post:

Hey @app_deployers,

There is a request to add a new library to App that we need to consider. Please look at this GH and then vote :+1: or :-1: on accepting this new library or not.

GH_LINK

[aimane-chnaif]

cc: @dangrous

[grgia]

I haven't had a chance to look into this- @dangrous let me know if you have additional context. I'll take a look shortly

[dangrous]

Summary is, it allows for preloading of components:

1️⃣ preload the component in advance to be able to mount it synchronously on a demand
If we mount the component and the component is lazy and haven't been loaded yet, then when we switch navigator we remove old navigator, but a new one navigator doesn't have routes yet, so react-navigation clears a state, and when new routes are attached then a default route will be selected, because previous state was lost.

So we need to mount the screen/navigator synchronously.

[grgia]

I think we can 👍 this.

Alternatives: We can write a preloading mechanism ourself. It's just a matter of an additional code that will be present in Expensify codebase which we'll need to support.

@kirillzyusko would this be time-consuming or hard to build on our own?

[kirillzyusko]

@grgia I don't think it'll be time consuming, but from the other side I don't see a lot of sense in re-implementation that code directly inside the Expensify app, because:

• it will be an additional code that we need to support;
• new code will be identical to what's present in react-native-bundle-splitter

So I would vote for adding the library and don't add additional code to the Expensify codebase if possible 🙃