[HOLD for payment 2024-11-18] [$250] New users seeing Expensify (notifications@expensify.com) in Contacts

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.40-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727214973622039

Action Performed:

1. Sign up for a new account
2. Selected Manage my team as intention
3. Go through onboarding
4. Select Start chat

Expected Result:

Expensify DM not displayed in contacts as it is deprecated

Actual Result:

Expensify (notifications@expensify.com)is displayed in my contacts

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.574.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021839750030898104642
• Upwork Job ID: 1839750030898104642
• Last Price Increase: 2024-10-04
• Automatic offers:
• ahmedGaber93 | Reviewer | 104411774
• Nodebrute | Contributor | 104411779

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-09-30 21:09:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

New users seeing Expensify (notifications@expensify.com) in Contacts

What is the root cause of that problem?

In here we are not excluding the CONST.EMAIL.NOTIFICATIONS

What changes do you think we should make in order to solve the problem?

We should add CONST.EMAIL.NOTIFICATIONS in excluded emails here We can do something like the pseudo code

   const excludedEmails = isGroupChat 
    ? excludedGroupEmails
    : [CONST.EMAIL.NOTIFICATIONS];

and then we can pass excludedEmails here

A more clean way to do this will be by passing CONST.EMAIL.NOTIFICATIONS here

 isGroupChat ? excludedGroupEmails : [CONST.EMAIL.NOTIFICATIONS]

What alternative solutions did you explore? (Optional)

We can add here CONST.EMAIL.NOTIFICATIONS

App/src/libs/OptionsListUtils.ts

Line 1910 in dc74ee3

const optionsToExclude: Option[] = [];

   const optionsToExclude: Option[] = [{login: CONST.EMAIL.NOTIFICATIONS}];

[mkzie2]

Edited by proposal-police: This proposal was edited at 2023-10-03T22:41:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify notifications@expensify.com is displayed in my contacts.

What is the root cause of that problem?

• The notifications@expensify.com account sends automated messages when SmartScan fails. We've already prevented users from chatting with this account and hidden it from search and the LHN in this PR. However, since it's been a while and we've refactored our search logic, we're now missing a few cases where the notifications@expensify.com email also needs to be filtered out.

• All our report and contact data across the search pages come from the OptionsListContextProvider. Within this provider, we use createOptionList to generate the options, but it does not filter out contacts where its login is notifications@expensify.com.

What changes do you think we should make in order to solve the problem?

We should add:

?.filter((o) => o.login !== CONST.EMAIL.NOTIFICATIONS)

to this data:

App/src/libs/OptionsListUtils.ts

Line 1553 in dc74ee3

}));

• This will ensure that all notification emails are filtered out across the search pages and improve the app's performance, as we're using OptionsListContextProvider, which only updates its data when the personalDetailList changes.

[mkzie2]

Proposal updated

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[joekaufmanexpensify]

Reproduced.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021839750030898104642