[HOLD for payment 2024-11-01] [$250] Bank account - User is able to edit account number but the change does not take affect

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.40-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5009304
Email or phone of affected tester (no customers): applausetester+vd_ios092524@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Pre-requisite: user must have created a Workspace and have enabled Workflows

1. Go to Settings > Workspaces > Workspace > Workflows
2. Click on "Connect bank account"
3. Select "Connect manually"
4. Enter "011401533" in routing number field
5. Enter "1111222233334444" in account number field and confirm
6. Go back by clicking on the arrow on the top left of the modal
7. Verify the user is able to edit the account number
8. Delete the "4444" part and enter "1111", then confirm
9. Go back again
10. Verify the account number has not changed

Expected Result:

Behavior should be consistent, if the user is able to edit the account number, the change should take affect

Actual Result:

Behavior is not consistent, the user is able to edit the account number but the changed does not take effect

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6615499_1727311085437.bandicam_2024-09-25_20-29-30-959.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021840583568266999203
• Upwork Job ID: 1840583568266999203
• Last Price Increase: 2024-09-30
• Automatic offers:
• suneox | Reviewer | 104229719
• DylanDylann | Contributor | 104533160
• cretadn22 | Contributor | 104533363

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account number is editable but reverted to previous value when saved.

What is the root cause of that problem?

When we try to edit the bank account number, the BE will return back the previous entered value.

So, it looks like we are not allowed to change the number after we entered it and need to start over the process.

What changes do you think we should make in order to solve the problem?

Disable the bank account number field if we already entered it. We can check using hasBankAccountData to disable it.

App/src/pages/ReimbursementAccount/BankInfo/substeps/Manual.tsx

Lines 78 to 101 in da37289

	<InputWrapper
	InputComponent={TextInput}
	ref={inputCallbackRef}
	inputID={BANK_INFO_STEP_KEYS.ROUTING_NUMBER}
	label={translate('bankAccount.routingNumber')}
	aria-label={translate('bankAccount.routingNumber')}
	role={CONST.ROLE.PRESENTATION}
	defaultValue={defaultValues[BANK_INFO_STEP_KEYS.ROUTING_NUMBER]}
	inputMode={CONST.INPUT_MODE.NUMERIC}
	shouldSaveDraft
	shouldUseDefaultValue={hasBankAccountData}
	/>
	<InputWrapper
	InputComponent={TextInput}
	inputID={BANK_INFO_STEP_KEYS.ACCOUNT_NUMBER}
	containerStyles={[styles.mt6]}
	label={translate('bankAccount.accountNumber')}
	aria-label={translate('bankAccount.accountNumber')}
	role={CONST.ROLE.PRESENTATION}
	defaultValue={defaultValues[BANK_INFO_STEP_KEYS.ACCOUNT_NUMBER]}
	inputMode={CONST.INPUT_MODE.NUMERIC}
	shouldSaveDraft
	shouldUseDefaultValue={hasBankAccountData}
	/>

disabled={hasBankAccountData}

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user can edit the account number, but the change does not take effect.

What is the root cause of that problem?

When the user enters the bank account number and routing number, we need to verify them on the backend before the user moves to the next step. If the user edits the bank account number again, the backend still retain the previous value.

What changes do you think we should make in order to solve the problem?

We should disable both the routing number field and the bank account number field if hasBankAccountData is true.

Add disabled={hasBankAccountData} to two places

App/src/pages/ReimbursementAccount/BankInfo/substeps/Manual.tsx

Lines 78 to 101 in da37289

	<InputWrapper
	InputComponent={TextInput}
	ref={inputCallbackRef}
	inputID={BANK_INFO_STEP_KEYS.ROUTING_NUMBER}
	label={translate('bankAccount.routingNumber')}
	aria-label={translate('bankAccount.routingNumber')}
	role={CONST.ROLE.PRESENTATION}
	defaultValue={defaultValues[BANK_INFO_STEP_KEYS.ROUTING_NUMBER]}
	inputMode={CONST.INPUT_MODE.NUMERIC}
	shouldSaveDraft
	shouldUseDefaultValue={hasBankAccountData}
	/>
	<InputWrapper
	InputComponent={TextInput}
	inputID={BANK_INFO_STEP_KEYS.ACCOUNT_NUMBER}
	containerStyles={[styles.mt6]}
	label={translate('bankAccount.accountNumber')}
	aria-label={translate('bankAccount.accountNumber')}
	role={CONST.ROLE.PRESENTATION}
	defaultValue={defaultValues[BANK_INFO_STEP_KEYS.ACCOUNT_NUMBER]}
	inputMode={CONST.INPUT_MODE.NUMERIC}
	shouldSaveDraft
	shouldUseDefaultValue={hasBankAccountData}
	/>

App/src/pages/ReimbursementAccount/BankInfo/substeps/Manual.tsx

Line 90 in da37289

<InputWrapper

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021840583568266999203

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)