[HOLD for payment 2024-11-29] [$250] Room - Create room whisper reappears when interacting with it after workspace is deleted

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Send a mention of a non-existing room
4. Delete the workspace
5. Go to workspace chat
6. Click Yes on the whisper

Expected Result:

The whisper should be removed once the workspace is deleted

Actual Result:

The whisper is not removed after the workspace is deleted
When user selects Yes or No, the whisper disappears and reappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6619523_1727631494594.20240930_013404.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021840941316454719982
• Upwork Job ID: 1840941316454719982
• Last Price Increase: 2024-10-08
• Automatic offers:
• rayane-djouah | Reviewer | 104326547
• Krishna2323 | Contributor | 104326549

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - Create room whisper reappears when interacting with it after workspace is deleted

What is the root cause of that problem?

We still displaying the whisper action although the workspace is deleted or the report is archived

What changes do you think we should make in order to solve the problem?

Return false on shouldReportActionBeVisible if the report is archived and the report action is whisper action here

    if (isWhisperAction(reportAction) && ReportUtils.isArchivedRoom(report)) {
        return false;
    }

add report param to shouldReportActionBeVisible and make it nullable

Then pass the report here

App/src/pages/home/report/ReportActionsList.tsx

Line 197 in e84dab7

ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID),

ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID, report),

What alternative solutions did you explore? (Optional)

[Nomanahmeda789]

Proposal

Please re-state the problem that we are trying to solve in this issue.
Room - Create room whisper reappears when interacting with it after workspace is deleted

What is the root cause of that problem?
We still displaying the whisper action although the workspace is deleted or the report is archived

What changes do you think we should make in order to solve the problem?
Need to implement logic that can conditionally render the "Create room whisper" based on the workspace's existence. A simple check is need to added before rendering the whisper to check that the workspace is still valid like this:

if (!workspaceExists) return null;

[Muhammad-Maraj-Khan]

Somewhat agree with @Nomanahmeda789 solution.

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Create room whisper reappears when interacting with it after workspace is deleted

What is the root cause of that problem?

Currently, we are still showing whispers even when the workspace is deleted.

App/src/pages/home/report/ReportActionsList.tsx

Lines 193 to 197 in 1d0fa64

	(isOffline ||
	ReportActionsUtils.isDeletedParentAction(reportAction) ||
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ||
	reportAction.errors) &&
	ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID),

What changes do you think we should make in order to solve the problem?

We should add logic to check if it's a whisper, and if the workspace is deleted, then it should not be shown. Some thing like that:

// .src/pages/home/report/ReportActionsList.tsx#L188
+    const isArchivedRoom = ReportUtils.isArchivedRoom(report, reportNameValuePairs);

// .src/pages/home/report/ReportActionsList.tsx#L197
reportAction.errors) && 
- ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID)
+ ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID) &&
+                    (reportAction.actionName !== 'ACTIONABLEREPORTMENTIONWHISPER' || !isArchivedRoom)

Details

POC

Screen.Recording.2024-10-01.at.00.16.10.mp4

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-10-01 04:43:52 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

Room - Create room whisper reappears when interacting with it after workspace is deleted

What is the root cause of that problem?

In shouldReportActionBeVisible, we are not checking whether the report is writeable, and we also don't check for this in ReportActionsList.

App/src/libs/ReportActionsUtils.ts

Lines 625 to 667 in a85cde8

	function shouldReportActionBeVisible(reportAction: OnyxEntry<ReportAction>, key: string | number): boolean {
	if (!reportAction) {
	return false;
	}
	if (isReportActionDeprecated(reportAction, key)) {
	return false;
	}
	// Filter out any unsupported reportAction types
	if (!supportedActionTypes.includes(reportAction.actionName)) {
	return false;
	}
	// Ignore closed action here since we're already displaying a footer that explains why the report was closed
	if (reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.CLOSED) {
	return false;
	}
	// Ignore markedAsReimbursed action here since we're already display message that explains the expense was paid
	// elsewhere in the IOU reportAction
	if (reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.MARKED_REIMBURSED) {
	return false;
	}
	if (isWhisperActionTargetedToOthers(reportAction)) {
	return false;
	}
	if (isPendingRemove(reportAction) && !reportAction.childVisibleActionCount) {
	return false;
	}
	if (isTripPreview(reportAction)) {
	return true;
	}
	// All other actions are displayed except thread parents, deleted, or non-pending actions
	const isDeleted = isDeletedAction(reportAction);
	const isPending = !!reportAction.pendingAction;
	return !isDeleted || isPending || isDeletedParentAction(reportAction) || isReversedTransaction(reportAction);
	}

App/src/pages/home/report/ReportActionsList.tsx

Lines 189 to 200 in d589746

	const sortedVisibleReportActions = useMemo(
	() =>
	sortedReportActions.filter(
	(reportAction) =>
	(isOffline ||
	ReportActionsUtils.isDeletedParentAction(reportAction) ||
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ||
	reportAction.errors) &&
	ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID),
	),
	[sortedReportActions, isOffline],
	);

What changes do you think we should make in order to solve the problem?


We have 2 solutions to solve this issue.

• Add ReportUtils.canUserPerformWriteAction check in shouldReportActionBeVisible util function.
  • For this we can pass the report to shouldReportActionBeVisible and then use canUserPerformWriteAction with the report and return false is !canUserPerformWriteAction is false. We also need to check if the action is a whisper or not and based on that we will return the boolean.

function shouldReportActionBeVisible(reportAction: OnyxEntry<ReportAction>, key: string | number,report): boolean {
    if ((isActionableMentionWhisper(reportAction) || isActionableTrackExpense(reportAction) || isActionableReportMentionWhisper(reportAction)) && !canUserPerformWriteAction(report)) {
        return false;
    }
    
    // We can also consider checking isActionableJoinRequest & isActionableJoinRequestPending

What alternative solutions did you explore? (Optional)

• Alternatively we can move the hideComposer at the top level of the component and then use it here in the condition.
  

  App/src/pages/home/report/ReportActionsList.tsx

  Line 546 in d589746

  const hideComposer = !ReportUtils.canUserPerformWriteAction(report);

Result

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021840941316454719982

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)