[HOLD for payment 2024-12-20] [$250] mWeb - Submit expense- "Hmm it's not here" message gets visible when deleting vague distance Expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.41-10
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): testpayment935+222@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go Offline
2. Global Create > Submit expense
3. Select Distance option
4. Disable the internet connection
5. Enter a vague start location, random characters
6. Enter a vague finish location, random characters
7. Finish the submit creation flow
8. Enable the internet connection
9. Click on the close icon of error message displayed

Expected Result:

Delete the vague distance expense without problem

Actual Result:

"Hmm it's not here" message gets visible for a second before deleting the expense

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6621450_1727809746483.Mweb_Hmm_page_before_deleting_vague_location_distance_expense.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021847129435512475314
• Upwork Job ID: 1847129435512475314
• Last Price Increase: 2024-10-25
• Automatic offers:
• rayane-djouah | Reviewer | 104681071
• truph01 | Contributor | 104681072

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[truph01]

Edited by proposal-police: This proposal was edited at 2024-10-18 04:23:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Hmm it's not here" message gets visible for a second before deleting the expense

What is the root cause of that problem?

• We clear the report data and go back in:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 496 to 497 in ea48de3

	const urlToNavigateBack = IOU.cleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
	Navigation.goBack(urlToNavigateBack);

• When the go-back action is not finished, and the onyx data is updated successfully, the "Hmm its not here" screen is displayed for a while.

What changes do you think we should make in order to solve the problem?

• Remove the code:

App/src/pages/home/ReportScreen.tsx

Line 272 in c3d33fc

wasReportAccessibleRef.current = false;

will fix the issue because if the report is visited before, there is no not here page is displayed anymore.

What alternative solutions did you explore? (Optional)

• We should go back successfully and then clear the report data.

• We can do it by:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 496 to 497 in ea48de3

	const urlToNavigateBack = IOU.cleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
	Navigation.goBack(urlToNavigateBack);

                            const {urlToNavigateBack} = IOU.prepareToCleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
                            Navigation.goBack(urlToNavigateBack);
                            InteractionManager.runAfterInteractions(() => {
                                IOU.cleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
                            });

[alexpensify]

Adding this one to my test list and will get to it later this week.

[alexpensify]

No update yet

[melvin-bot]

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alexpensify]

Still on my testing list