[HOLD for payment 2024-10-11] Search - Expenses are not highlighted when selected

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh300901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• There are at least two expenses submitted to the other user.

1. Go to staging.new.expensify.com
2. Go to Search.
3. Select the expenses via checkbox.
4. Note that the selected expenses are not highlighted.
5. Go to Outstanding.
6. Select all expenses via checkbox.
7. Note that the report header for the group expenses is not highlighted.

Expected Result:

The expenses will be highlighted when selected (production behavior).

Actual Result:

In Step 4, the selected expenses in All tab are not highlighted.
In Step 7, the report header for the group expenses is not highlighted.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6622006_1727865495202.high.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 4, the selected expenses in All tab are not highlighted.
In Step 7, the report header for the group expenses is not highlighted.

What is the root cause of that problem?

We override the focused background and selected background style here and here

It's only applied when we hover over the report item.

What changes do you think we should make in order to solve the problem?

We should move the style here and here above the selected background and focused background style here and here

What alternative solutions did you explore? (Optional)

[Krishna2323]

Regression from #49192

cc: @ikevin127 @ishpaul777

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.