[HOLD for payment 2024-10-25] [$250] [Dupe detect] Not here page opens when opening distance receipt from another workspace

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.43-3
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create two workspaces.
3. Submit a distance expense in the first workspace chat.
4. Submit the same distance expense in the second workspace chat.
5. Submit another expense to the second workspace chat (as we cannot review duplicates when there is only one expense).
6. Go to transaction thread of the second expense in Step 4.
7. Click Review duplicates.
8. Click on the second distance expense preview (to make Keep this one button appear).
9. Click browser back button.
10. Click Keep this one on the second expense preview.
11. Click on the receipt on the confirmation page.

Expected Result:

The receipt opens without issue.

Actual Result:

Not here page opens when opening distance receipt from another workspace in full screen.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6622310_1727885989783.20241003_001259.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021842274975898423185
• Upwork Job ID: 1842274975898423185
• Last Price Increase: 2024-10-04
• Automatic offers:
• rojiphil | Reviewer | 104346977
• nkdengineer | Contributor | 104346978

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page opens when opening distance receipt from another workspace in full screen.

What is the root cause of that problem?

Here we are calculating shouldShowNotFoundPage based on moneyRequestReportID and transaction?.reportID and will show NotFoundPage when they are different

App/src/pages/TransactionReceiptPage.tsx

Line 62 in c3b4a65

const shouldShowNotFoundPage = isTrackExpenseReport || transaction?.reportID === CONST.REPORT.SPLIT_REPORTID ? !transaction : (moneyRequestReportID ?? '-1') !== transaction?.reportID;

But in case review duplicates with expsense in another workspace, it is no longer true because this transaction does not belong to the same report so moneyRequestReportID will calculate wrong

App/src/pages/TransactionReceiptPage.tsx

Line 58 in c3b4a65

const moneyRequestReportID = ReportUtils.isMoneyRequestReport(report) ? report?.reportID : report?.parentReportID;

What changes do you think we should make in order to solve the problem?

1. We should add new route param like isFromReviewDuplicates for route TRANSACTION_RECEIPT here

    TRANSACTION_RECEIPT: {
        route: 'r/:reportID/transaction/:transactionID/receipt',
        getRoute: (reportID: string, transactionID: string, readonly = false, isFromReviewDuplicates = false) => `r/${reportID}/transaction/${transactionID}/receipt${readonly ? '?readonly=true' : ''}${isFromReviewDuplicates ? '?isFromReviewDuplicates=true' : ''}` as const,
    },

2. Use this param when calculating shouldShowNotFoundPage here

    const shouldShowNotFoundPage = isTrackExpenseReport || transaction?.reportID === CONST.REPORT.SPLIT_REPORTID || isFromReviewDuplicates ? !transaction : (moneyRequestReportID ?? '-1') !== transaction?.reportID;

3. We can pass isFromReviewDuplicates from Transaction Duplicate confirmation page here

App/src/pages/TransactionDuplicate/Confirmation.tsx

Lines 107 to 112 in c3b4a65

	<MoneyRequestView
	report={report}
	shouldShowAnimatedBackground={false}
	readonly
	updatedTransaction={transaction as OnyxEntry<Transaction>}
	/>

What alternative solutions did you explore? (Optional)

[joekaufmanexpensify]

I can reproduce this, but not sure if dupe detection across multiple workspaces is supposed to be a thing.

[joekaufmanexpensify]

Discussing

[joekaufmanexpensify]

Confirmed this is possible, but only for the submitter. Given the submitter can view the expense when resolving dupes, feels correct they should be able to view the receipt.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021842274975898423185