[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Sign up - No error indicating that magic code is incorrect when validating account via Wallet

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.44-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): yonghongkok2+dsposjpds@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new Gmail account.
3. Complete onboarding.
4. Go to Account settings > Wallet.
5. Click Add bank account.
6. Enter incorrect magic code.

Expected Result:

There will be error indicating that the magic code is incorrect.

Actual Result:

There is no error indicating that the magic code is incorrect.
Nothing happens after entering incorrect magic code.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6623233_1727962472420.no_error.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[drminh2807]

Edited by proposal-police: This proposal was edited at 2024-10-03 14:56:37 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sign up - No error indicating that magic code is incorrect when validating account via Wallet

What is the root cause of that problem?

Wrong reason for clear error

What changes do you think we should make in order to solve the problem?

App/src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

Lines 128 to 134 in cb58008

	useEffect(() => {
	if (!validateError) {
	return;
	}
	clearError();
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
	}, [clearError, validateError]);

always clearError when mount, no add validateError to dependencies

    useEffect(() => {
        clearError();
        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
    }, []);

What alternative solutions did you explore? (Optional)

NA

[jasperhuangg]

This is a bug that wasn't caught during review in #49230