[HOLD for payment 2024-10-14] [$125] Add "clear" button to saved search name field

[dannymcclain]

Problem

Saved searches often have super long names, so when users go to rename them, it's cumbersome to clear the name input.

Solution

Let's add the "clear" button that we added to the Group name input to solve the same problem.

Notes

• The clear button for the saved search name field should look and function identically to the one in the group name field.

cc @Expensify/design @roryabraham

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841865344980745582
• Upwork Job ID: 1841865344980745582
• Last Price Increase: 2024-10-03
• Automatic offers:
• dukenv0307 | Reviewer | 104256804
• nyomanjyotisa | Contributor | 104256806

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021841865344980745582

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add "clear" button to saved search name field

What is the root cause of that problem?

Change request

What changes do you think we should make in order to solve the problem?

Add shouldShowClearButton here

App/src/pages/Search/SavedSearchRenamePage.tsx

Lines 62 to 71 in 897da0e

	<InputWrapper
	InputComponent={TextInput}
	inputID={INPUT_IDS.NAME}
	label={translate('search.searchName')}
	accessibilityLabel={translate('search.searchName')}
	role={CONST.ROLE.PRESENTATION}
	onChangeText={(renamedName) => setNewName(renamedName)}
	ref={inputCallbackRef}
	defaultValue={name}
	/>

What alternative solutions did you explore? (Optional)

[dukenv0307]

@nyomanjyotisa Since it's the new design, can you share the video/sceenshots

[nyomanjyotisa]

Here is the screenshot:

identically to the one in the group name field