[HOLD for payment 2024-10-24] [$250] Expensify Card -App returns to card feed selection page after issuing card from member profile

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.44-7
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Bank account is already set up in Expensify Card page.
• Company card feature is enabled.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Members.
3. Click on any member.
4. Click New Card.
5. Click Expensify Card.
6. Go through the setup process.
7. Click Issue card on the confirmation page.

Expected Result:

App will return to member profile page after issuing card from member profile.

Actual Result:

App returns to card feed selection page after issuing card from member profile.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6624197_1728034246752.20241004_171833.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021843172551777303100
• Upwork Job ID: 1843172551777303100
• Last Price Increase: 2024-10-07
• Automatic offers:
• paultsimura | Reviewer | 104321384
• abzokhattab | Contributor | 104321385

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 2

[IuliiaHerets]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2024-10-04 14:45:09 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card -App returns to card feed selection page after issuing card from member profile

What is the root cause of that problem?

The backTo route is incorrectly set to activeRoute, which is the feed selector page, causing it to loop continuously

App/src/pages/workspace/members/WorkspaceMemberNewCardPage.tsx

Line 84 in 0e21365

Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID, activeRoute));

What changes do you think we should make in order to solve the problem?

we should change the back to the workspace member detail page

Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID, ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID)));

What alternative solutions did you explore? (Optional)

Another solution would be to add backTo to this route, and then use it here. However, I don't think we should do that, since this route is only navigated to once in the code, so we can confidently hardcode the backTo

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to card feed selection page after issuing card from member profile

What is the root cause of that problem?

We always return the backTo parameter after a new card is created

App/src/pages/workspace/expensifyCard/issueNew/ConfirmationStep.tsx

Line 50 in b9d9686

Navigation.navigate(backTo ?? ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policyID ?? '-1'));

In this scenario, the navigation stack will be: IssueNewCardPage > WorkspaceMemberNewCardPage > WorkspaceMemberDetailsPage. Therefore, the backTo parameter for IssueNewCardPage will be WorkspaceMemberNewCardPage, then the app to navigate back to WorkspaceMemberNewCardPage

What changes do you think we should make in order to solve the problem?

We shouldn't navigate to backTo when the user submits a new card; the backTo parameter should only be used when users click the back button

We should check if users create a card in WorkspaceMemberDetailsPage, and if so, navigate them back to that page after creating the new card by checking the backTo parameter.

        if (backTo && backTo.includes('expensify-card')) {
            Navigation.navigate(backTo ?? ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policyID ?? '-1'));
        } else {
            const accountID = PersonalDetailsUtils.getPersonalDetailByEmail(data?.assigneeEmail ?? '')?.accountID
            Navigation.navigate(ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID ?? -1));
        }

What alternative solutions did you explore? (Optional)

Alternatively, we can use the background screen from "state.FullScreenNavigator" to determine which page to navigate to when the user submits a card.

If the background screen is the Expensify Card Page, we will navigate to that page.
If the background screen is the Member Page, we will navigate to the Member Detail Page.

        const stateTopmostFullScreen = getTopmostFullScreenRoute(navigationRef.getRootState());
        if (stateTopmostFullScreen && stateTopmostFullScreen.name === SCREENS.WORKSPACE.MEMBERS) {
            const accountID = PersonalDetailsUtils.getPersonalDetailByEmail(data?.assigneeEmail ?? '')?.accountID
            Navigation.navigate(ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID ?? -1));
        } else {
            Navigation.navigate(backTo ?? ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policyID ?? '-1'));
        }

[Christinadobrzyn]

I'm not sure if this needs to be a backend but since we have a proposal let's start with External

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021843172551777303100