[Due for payment 2025-02-13] [$250] Submit expense RHP doesn't include workspaces from Track flow

[shawnborton]

Problem:
When you Track an expense, you can then submit it to someone. However, the list of contacts shown on this screen differs from the same contacts you would see if you first chose Submit expense from global create.

Track sees this:

Submit sees this:

Solution:
Let's make sure the Submit expense RHP flow looks identical no matter if you chose Track or Submit. This will fix the inconsistency in the product, and it also helps our chances for conversion as it unhides submitting an expense to a workspace from this flow.

cc @anmurali @JmillsExpensify to file this one, I think it is a #convert issue

We should also fix #52249 (comment) as part of this issue

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021850835832011853233
• Upwork Job ID: 1850835832011853233
• Last Price Increase: 2024-10-28
• Automatic offers:
• FitseTLT | Contributor | 104698445

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021850835832011853233

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit expense RHP doesn't include workspaces from Track flow

What is the root cause of that problem?

We do not include here for track expense

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Line 126 in aa25823

includeOwnedWorkspaceChats: (iouType === CONST.IOU.TYPE.SUBMIT || iouType === CONST.IOU.TYPE.CREATE || iouType === CONST.IOU.TYPE.SPLIT) && action !== CONST.IOU.ACTION.SUBMIT,

What changes do you think we should make in order to solve the problem?

We should include track expense as well

includeOwnedWorkspaceChats: (iouType === CONST.IOU.TYPE.SUBMIT || iouType === CONST.IOU.TYPE.CREATE || iouType === CONST.IOU.TYPE.SPLIT || iouType === CONST.IOU.TYPE.TRACK) && action !== CONST.IOU.ACTION.SUBMIT,

Result

What alternative solutions did you explore? (Optional)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Submit to someone track option opens a participant page without including workplace chat.

What is the root cause of that problem?

We are currently excluding workspace from the participant list if the ACTION is SUBMIT.

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Line 126 in 186c1a9

includeOwnedWorkspaceChats: (iouType === CONST.IOU.TYPE.SUBMIT || iouType === CONST.IOU.TYPE.CREATE || iouType === CONST.IOU.TYPE.SPLIT) && action !== CONST.IOU.ACTION.SUBMIT,

What changes do you think we should make in order to solve the problem?

Remove the action SUBMIT condition

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Line 126 in 186c1a9

includeOwnedWorkspaceChats: (iouType === CONST.IOU.TYPE.SUBMIT || iouType === CONST.IOU.TYPE.CREATE || iouType === CONST.IOU.TYPE.SPLIT) && action !== CONST.IOU.ACTION.SUBMIT,

&& action !== CONST.IOU.ACTION.SUBMIT

But I have a concern. The action currently reads "Submit it to someone". Is workspace considered "someone"? If not, I think we should rephrase it.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit expense RHP doesn't include workspaces from Track flow

What is the root cause of that problem?

We are currently not allowing workspaces through the Submit it to someone operation so we disallow the option for distance requests if P2P distance is not enabled

App/src/pages/home/report/ReportActionItem.tsx

Line 424 in 5103b4b

...(!TransactionUtils.isDistanceRequest(TransactionUtils.getTransaction(transactionID ?? '-1')) || canUseP2PDistanceRequests

and in participants we are not including workspaces if the action is submit

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Line 126 in 186c1a9

includeOwnedWorkspaceChats: (iouType === CONST.IOU.TYPE.SUBMIT || iouType === CONST.IOU.TYPE.CREATE || iouType === CONST.IOU.TYPE.SPLIT) && action !== CONST.IOU.ACTION.SUBMIT,

What changes do you think we should make in order to solve the problem?

1. we need to remove this condition here to allow the option to be visible for distance requests even if the P2P is disabled
   

   App/src/pages/home/report/ReportActionItem.tsx

   Line 424 in 5103b4b

   ...(!TransactionUtils.isDistanceRequest(TransactionUtils.getTransaction(transactionID ?? '-1')) || canUseP2PDistanceRequests

2. remove the submit action condition here
   

   App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

   Line 126 in 186c1a9

   includeOwnedWorkspaceChats: (iouType === CONST.IOU.TYPE.SUBMIT || iouType === CONST.IOU.TYPE.CREATE || iouType === CONST.IOU.TYPE.SPLIT) && action !== CONST.IOU.ACTION.SUBMIT,

            includeOwnedWorkspaceChats: iouType === CONST.IOU.TYPE.SUBMIT || iouType === CONST.IOU.TYPE.CREATE || iouType === CONST.IOU.TYPE.SPLIT,

What alternative solutions did you explore? (Optional)

[hoangzinh]

we need to remove this condition here to allow the option to be visible for distance requests even if the P2P is disabled

Hi, @FitseTLT could you elaborate on this one? I'm unable to create a track expense with Distance request

[FitseTLT]

@hoangzinh Quite odd, I can create a distance track expense even without enabling beta

2024-10-29.14-27-05.mp4