[HOLD for payment 2024-12-09] [$250] Members- Refresh while on the WS invite message page empty show invite message again

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.55-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #51228

Action Performed:

1. Open the WS invite page
2. Select any user and go next
3. Empty the message
4. Refresh the page

Expected Result:

Refresh while on the WS invite message page with empty message should show message place empty as it was before refreshed

Actual Result:

Refresh while on the WS invite message page empty show invite message all over again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6649184_1730199210689.Screen_Recording_20241029_133649_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021853393721581519961
• Upwork Job ID: 1853393721581519961
• Last Price Increase: 2024-11-25
• Automatic offers:
• allgandalf | Reviewer | 105068622
• wildan-m | Contributor | 105068623

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-11-12 11:23:24 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Members- Refresh while on the WS invite message page empty show invite message again

What is the root cause of that problem?

We save the draft invite message in workspaceInviteMessageDraft and when reloading we load the message in getDefaultWelcomeNote

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Line 71 in c3dde46

workspaceInviteMessageDraft ||

but we are using || after workspaceInviteMessageDraft so when workspaceInviteMessageDraft is an empty string (empty string is considered as falsy in javascript) so it will load the initial default copy here

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Line 75 in c3dde46

translate('workspace.common.welcomeNote', {

What changes do you think we should make in order to solve the problem?

We should use ?? instead

            workspaceInviteMessageDraft ??

and then we should make sure the draft is always reset whenever the user navigates to invite message page

App/src/pages/workspace/WorkspaceInvitePage.tsx

Line 266 in c3dde46

Member.setWorkspaceInviteMembersDraft(route.params.policyID, invitedEmailsToAccountIDs);

        Policy.setWorkspaceInviteMessageDraft(route.params.policyID, null);

What alternative solutions did you explore? (Optional)

[melvin-bot]

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021853393721581519961

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)